Data #364
Merged
Data #364
+3,836
−2,303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dea why this needs committing :0
1. Remove nav.color.harsh.menu.bg-alt and nav.color.subtle.menu.bg-alt as we're aiming to simplify the menu component and only allow one bg colour. These pointed to base.color.generic.bg.<standard or inverse>.delicate.
2. Add descriptions to base.color.interactive.danger.standard hover tokens.
3. Add base.color.interactive.danger.standard.hoverAlt2 and base.color.interactive.primary.standard.hoverAlt for link hover.
4. Change value of link.color.standard.destructive.label-default from {base.color.interactive.danger.standard.default} to {...defaultAlt}.
5. Change value of link.color.standard.destructive.label-hover from {base.color.interactive.danger.standard.hover} to {...hoverAlt}.
6. Change value of link.color.inverse.subtle.label-hover from {base.color.interactive.monochrome.inverse.hover} to {...active} to be solid white.
7. Change value of link.color.standard.subtle.label-hover from {base.color.interactive.monochrome.standard.hover} to {...active} to be solid black.
8. Change value of datatable.color.row.bg-hover from mix ({base.color.generic.bg.inverse.nought} , 0.12) / lch {datatable.color.row.bg-default} dddddd to {base.color.generic.bg.standard.soft} dedede.
1. Remove nav.color.harsh.menu.bg-alt and nav.color.subtle.menu.bg-alt as we're aiming to simplify the menu component and only allow one bg colour. These pointed to base.color.generic.bg.<standard or inverse>.delicate.
2. Add descriptions to base.color.interactive.danger.standard hover tokens.
3. Add base.color.interactive.danger.standard.hoverAlt2 and base.color.interactive.primary.standard.hoverAlt for link hover.
4. Change value of link.color.standard.destructive.label-default from {base.color.interactive.danger.standard.default} to {...defaultAlt}.
5. Change value of link.color.standard.destructive.label-hover from {base.color.interactive.danger.standard.hover} to {...hoverAlt}.
6. Change value of link.color.inverse.subtle.label-hover from {base.color.interactive.monochrome.inverse.hover} to {...active} to be solid white.
7. Change value of link.color.standard.subtle.label-hover from {base.color.interactive.monochrome.standard.hover} to {...active} to be solid black.
8. Change value of datatable.color.row.bg-hover from mix ({base.color.generic.bg.inverse.nought} , 0.12) / lch {datatable.color.row.bg-default} dddddd to {base.color.generic.bg.standard.soft} dedede.
Remove unnecessary file
…eton. 2. Add container.color.scroll tokens. 3. Add progress.color.standard.fg-alt2 for step sequence.
…split button spacer
…dd form.color.calendar.bg-duration. 3. Update value of form.color.calendar.bg-hover.
…disabled, button.color.inverse.typical.primary.label-disabled, button.color.standard.typical.primary.bg-disabled and button.color.standard.typical.primary.label-disabled
…rder-disabled and button.color.standard.typical.tertiary.border-disabled
…we think we don't need them. For now they are FF00FF. The plan is to delete these
…ders as we think we don't need these tokens. Coloured FF00FF for now. Plan to remove these tokens later
…or.interactive.ai.standard. 3. Add button.color.standard.typical.ai tokens
…d base.color.interactive.ai.inverse. 4. Add button.color… .ai.bg-hover. 5. Add button.color.inverse tokens. 6. add progress.color... fg-ai tokens. 7. Update weight values of global.typography.web.component.firm XS and S to be medium not regular.
…r. 2. Rename global.box-shadow.interactive.hover to … distant. 3. Update description on global.border-radius tokens. 4. Create global.border-radius.interactive.XXL.
…ecific tokens - button, popover, tab. 2. Update description on global.border-radius.interactive.M, global.border-radius.interactive.XL and global.border-radius.interactive.XXL. 3. Change global.border-radius.interactive.none to global.border-radius.none.
… easily override scaling for different themes in future
….label-disabled and button.color.standard.typical.primary.label-disabled to {base.color.interactive.inactive.standard.content}
…ard.hover to origin.colors.black. Update value of base.color.interactive.monochrome.inverse.hover to origin.colors.white. This gives us independent control of 1. Update value of base.color.interactive.monochrome.standard.hover to origin.colors.black. Update value of base.color.interactive.monochrome.....default tokens.
…dard.hover to origin.colors.black. Update value of base.color.interactive.monochrome.inverse.hover to origin.colors.white. 2. Move container.color.standard.interactive border and bg activated colours into container.color.standard. 3. Add container.color.standard.bgFooter-active, container.color.standard.bgFooter-activated, container.color.standard.border-active, and container.color.standard.border-activated. 4. Temporary change of container.color.standard.interactive.bgFooter-activated, container.color.standard.interactive.bgFooter-active, and container.color.standard.interactive.border-activated to FF00FF. They can probably be removed.
… Add borderradius to container and form component tokens. 3. Move button, form, popover and tab borderRadius tokens into parent folder named borderradius.
…k, form, progress, nav. 2. Rename datatable to table. 3. Update button border radius token descriptions.
…k pill tokens. 3. Update values of form.size.switch.container. 4. Add form.space.switch. 5. Reorder form code alphabetically. 6. Reorder global typography code alphabetically.
…generic - easier findability.
…t hierarchy of radius makes more sense in preview comp.
…ase from marketing
ljemmo
approved these changes
Mar 14, 2024
|
🎉 This PR is included in version 5.0.0-beta.18 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.