Fix LISFLOOD Errors when no lakes or reservoirs in the domain. #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running LISFLOOD over the SEED-FD domains there are errors for the domains that do not contain lakes/reservoirs due to missing expected input files. This is only a problem for warm starts.
This change adds a check to
checkers.py
so that if there are no lakes or reservoirs present then the input file check will not run for lakes/reservoirs.The lisflood code already handles domains without lakes or reservoirs within the
hydrological_modules/lakes.py
andhydrological_modules/reservoir.py
scripts so this deals with switching off the options in the model settings. This extra check just deals with the errors that happen before this stage when running checks on input files for model restarts.The same logic that is used in
hydrological_modules/lakes.py
andhydrological_modules/reservoir.py
, for determining where a lake/reservoir is present, is used in this new change tocheckers.py
.Tests carried out: