CXSPA/9197: Remove unused method in major release #19833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platonn
approved these changes
Jan 9, 2025
|
a year ago we deprecated officially (via JSDocs which are visible to customers) the original method and told customers to use the V2 method instead. Thanks to this advice, some of them them might have moved to V2, to adapt to the future breaking changes in advance.
|
pawelfras
reviewed
Jan 9, 2025
|
|
||
| //TODO: CXINT-2896: Rename this method to `getOrderDetails` in next major release | ||
| getOrderDetailsV2(code: string): Observable<Order | undefined> { | ||
| getOrderDetails(code: string): Observable<Order | undefined> { |
There was a problem hiding this comment.
major: Since the getOrderDetails method was deprecated with the information to use getOrderDetailsV2 instead, we should keep the one with V2 suffix to be in line with the deprecation message (and to be fair to our customers).
|
In addition to what Kris said, let's change target branch to |
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
CXSPA-9197-refactoring-myaccountv2
|
| Run status |
|
| Run duration | 11m 36s |
| Commit |
|
| Committer | anjana-bl |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
…CXSPA-9067)" (#19749) Co-authored-by: Radhep Sabapathipillai <34665674+RadhepS@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… from a category (#19576) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Closes: CXSPA-9124
…ner is visible and ensure clear visible focus for accessibility (#19728)
…BoxComponent (#19680) Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com>
…pacing settings (#19707)
Co-authored-by: Christoph Hinssen <33626130+ChristophHi@users.noreply.github.com>
…button (#19731) Co-authored-by: Christoph Hinssen <33626130+ChristophHi@users.noreply.github.com>
Closes CXSPA-9113
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com>
…19662) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com>
Closes: CXSPA-9130
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Giancarlo Cordero Ortiz <46171897+giancorderoortiz@users.noreply.github.com>
anjana-bl
force-pushed
the
CXSPA-9197-refactoring-myaccountv2
branch
from
586692f to
b845a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.tools.sap/browse/CXSPA-9197