CXCDS-14100: Remove sciEnabled value for profile-tag as it's never used.

SAP · Feb 6, 2025 · 7022df5 · 7022df5
1 parent c5d54c5
commit 7022df5
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 11 deletions.
diff --git a/integration-libs/cds/src/config/profile-tag.config.ts b/integration-libs/cds/src/config/profile-tag.config.ts
@@ -9,5 +9,4 @@ export interface ProfileTagConfig {
   configUrl?: string;
   allowInsecureCookies?: boolean;
   gtmId?: string;
-  sciEnabled?: boolean;
 }
diff --git a/integration-libs/cds/src/profiletag/model/profile-tag.model.ts b/integration-libs/cds/src/profiletag/model/profile-tag.model.ts
@@ -22,7 +22,6 @@ export interface ProfileTagJsConfig {
   configUrl?: string;
   allowInsecureCookies?: boolean;
   gtmId?: string;
-  sciEnabled?: boolean;
 }
 
 export interface ConsentReferenceEvent extends CustomEvent {

diff --git a/integration-libs/cds/src/profiletag/services/profiletag-event.service.spec.ts b/integration-libs/cds/src/profiletag/services/profiletag-event.service.spec.ts
@@ -26,7 +26,6 @@ const mockCDSConfig: CdsConfig = {
       configUrl: 'https:tag.static.us.context.cloud.sap',
       allowInsecureCookies: false,
       gtmId: 'test-id-1234567',
-      sciEnabled: false,
     },
   },
 };

diff --git a/integration-libs/cds/src/schematics/add-cds/__snapshots__/index_spec.ts.snap b/integration-libs/cds/src/schematics/add-cds/__snapshots__/index_spec.ts.snap
@@ -38,8 +38,7 @@ import { I18nConfig, provideConfig } from "@spartacus/core";
           'profile-tag-load-url.com',
         configUrl:
           'profile-tag-config-url.com',
-        allowInsecureCookies: true,
-        sciEnabled: false
+        allowInsecureCookies: true
       },
     },
   })
@@ -87,8 +86,7 @@ import { I18nConfig, provideConfig } from "@spartacus/core";
           'profile-tag-load-url.com',
         configUrl:
           'profile-tag-config-url.com',
-        allowInsecureCookies: true,
-        sciEnabled: true
+        allowInsecureCookies: true
       },
     },
   })
@@ -136,8 +134,7 @@ import { I18nConfig, provideConfig } from "@spartacus/core";
           'PROFILE_TAG_LOAD_URL_PLACEHOLDER',
         configUrl:
           'PROFILE_TAG_CONFIG_URL_PLACEHOLDER',
-        allowInsecureCookies: true,
-        sciEnabled: false
+        allowInsecureCookies: true
       },
     },
   })

diff --git a/projects/schematics/src/shared/lib-configs/integration-libs/cds-schematics-config.ts b/projects/schematics/src/shared/lib-configs/integration-libs/cds-schematics-config.ts
@@ -106,8 +106,7 @@ function buildCdsConfig(
                   options.profileTagConfigUrl ||
                   'PROFILE_TAG_CONFIG_URL_PLACEHOLDER'
                 }',
-              allowInsecureCookies: true,
-              sciEnabled: ${options.sciEnabled}
+              allowInsecureCookies: true
             },
           },
         }`,