Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jit regions fix #709

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Jit regions fix #709

wants to merge 2 commits into from

Conversation

LotP1
Copy link
Contributor

@LotP1 LotP1 commented Feb 23, 2025

Jit cache now fully resets when booting a game multiple times.
This should fix random jit cache crashes.
Also removed some redundant code related to region allocation and fixed PPTC Purge not fully purging all PPTC files in the backup folder.

Jit cache now fully resets when booting a second game.
This should fix random jit cache crashes.
Also removed some redundant code related to region allocation.
@github-actions github-actions bot added cpu An issue with ARMeilleure, the JIT, or Hypervisor gui Affects the Avalonia UI or translations. labels Feb 23, 2025
@FluffyOMC
Copy link
Contributor

Works on my test. Gets to

00:00:27.379 |I| GPU.MainThread Gpu LoadShaders: Shader cache loaded.
00:00:28.074 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 0 exhausted, creating new Cache Region 1 (512 MB Total Allocation).
00:00:29.021 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 1 exhausted, creating new Cache Region 2 (768 MB Total Allocation).
00:00:30.312 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 2 exhausted, creating new Cache Region 3 (1 GB Total Allocation).
00:00:32.049 |W| HLE.GuestThread.46 Cpu Allocate: JIT Cache Region 3 exhausted, creating new Cache Region 4 (1.25 GB Total Allocation).
00:00:32.101 |I| HLE.GuestThread.46 Ptc LoadTranslations: 165126 translated functions loaded

Both tries without crashing.

@Goodfeat
Copy link
Contributor

Goodfeat commented Feb 23, 2025

I'm not sure if it's a coincidence. But now if I launch the Mario and Luigi Brothership game, after stopping and restarting the game, the emulator no longer crashes.

It's just a problematic game, I decided to test it on it.
I tested it a couple dozen times. I cleaned the ppts for all test emulators, and only this build doesn't crash

P.S. No, it's not a coincidence. After launching Mario and Luigi Brothership, on the previous version of the emulator after stopping the game and restarting it on any other game, the emulator crashed with an error. This build works well

@FluffyOMC
Copy link
Contributor

I'm not sure if it's a coincidence. But now if I launch the Mario and Luigi Brothership game, after stopping and restarting the game, the emulator no longer crashes.

It's just a problematic game, I decided to test it on it.
I tested it a couple dozen times. I cleaned the ppts for all test emulators, and only this build doesn't crash

P.S. No, it's not a coincidence. After launching Mario and Luigi Brothership, on the previous version of the emulator after stopping the game and restarting it on any other game, the emulator crashed with an error. This build works well

Yeah, it's on purpose heh. This PR was entirely built because I noticed SSBU kept crashing with relaunches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpu An issue with ARMeilleure, the JIT, or Hypervisor gui Affects the Avalonia UI or translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants