-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jit regions fix #709
base: master
Are you sure you want to change the base?
Jit regions fix #709
Conversation
Jit cache now fully resets when booting a second game. This should fix random jit cache crashes. Also removed some redundant code related to region allocation.
Download the artifacts for this pull request: |
Works on my test. Gets to
Both tries without crashing. |
I'm not sure if it's a coincidence. But now if I launch the Mario and Luigi Brothership game, after stopping and restarting the game, the emulator no longer crashes. It's just a problematic game, I decided to test it on it. P.S. No, it's not a coincidence. After launching Mario and Luigi Brothership, on the previous version of the emulator after stopping the game and restarting it on any other game, the emulator crashed with an error. This build works well |
Yeah, it's on purpose heh. This PR was entirely built because I noticed SSBU kept crashing with relaunches. |
Jit cache now fully resets when booting a game multiple times.
This should fix random jit cache crashes.
Also removed some redundant code related to region allocation and fixed PPTC Purge not fully purging all PPTC files in the backup folder.