Improved interaction with "Input" settings. #708
Draft
+411
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- paired devices have notifications that they are configured and require connection - paired devices load the configuration when connected - A notification appears when changing control configuration settings. - Now control settings will be saved only when they are changed - Added a button to roll back changes to the previously saved state - Fixed a bug: when switching the "player", if the "input device" and "controller type" settings were changed, the save dialog box did not appear. - "Motion", "Rumble" and "Led" also have events notifying about changes
|
Download the artifacts for this pull request: |
…ton in the settings. - for keyboard - for hotkeys
This was referenced Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some fixes to the settings input section.
Changes and fixes:
bandicam.2025-02-22.22-27-48-129.mp4
The video shows some innovations:
The video shows some innovations:
If the controller is already configured, then the next time you enter the settings with the gamepad turned off, the inscription "Waiting for connection" is displayed in the "Input" settings section. When you connect the controller, its settings appear immediately.
The operation of the reset button is demonstrated. Some settings were changed, but not applied. The button in this case will roll back all changes to the last saved state.
When changing the settings, the word "modified" appears next to the word "Player", indicating that when applying the settings, the controller settings will also be saved.
Please note: the current pull request does not solve the problem with connecting the gamepad after rebooting the emulator! There is a separate topic for this
.