arduino-hal: update delay_ms to match embedded-hal API

Rahix · Jan 2, 2025 · 33ee7e6 · 33ee7e6
1 parent 57ccdae
commit 33ee7e6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/arduino-hal/src/delay.rs b/arduino-hal/src/delay.rs
@@ -10,9 +10,8 @@ pub type Delay = avr_hal_generic::delay::Delay<crate::DefaultClock>;
 ///
 /// Busy-loop for the given time.  This function assumes the default clock speed defined by
 /// [`arduino_hal::DefaultClock`][crate::DefaultClock].
-pub fn delay_ms(ms: u16) {
-    // TODO: update signature to match embedded-hal
-    Delay::new().delay_ms(ms.into())
+pub fn delay_ms(ms: u32) {
+    Delay::new().delay_ms(ms)
 }
 
 /// Delay execution for a number of microseconds.

diff --git a/examples/arduino-uno/src/bin/uno-ext-interrupt.rs b/examples/arduino-uno/src/bin/uno-ext-interrupt.rs
@@ -26,7 +26,7 @@ fn INT0() {
     REVERSED.store(!current, Ordering::SeqCst);
 }
 
-fn blink_for_range(range: impl Iterator<Item = u16>, leds: &mut [Pin<mode::Output>]) {
+fn blink_for_range(range: impl Iterator<Item = u32>, leds: &mut [Pin<mode::Output>]) {
     range.map(|i| i * 100).for_each(|ms| {
         let iter = if is_reversed() {
             Left(leds.iter_mut().rev())
@@ -35,7 +35,7 @@ fn blink_for_range(range: impl Iterator<Item = u16>, leds: &mut [Pin<mode::Outpu
         };
         iter.for_each(|led| {
             led.toggle();
-            arduino_hal::delay_ms(ms as u16);
+            arduino_hal::delay_ms(ms);
         })
     });
 }