-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up git-lfs and track relevant files #315
Conversation
Not sure why only the optional dependencies CI job fails, but the error seems relevant:
|
(Note: ⚙️ Push updated logo files is a temporary commit to verify that the "binary files... differ" error suggests that the git-lfs tracked logo files are still lingering somehow.) |
This reverts commit 3f47352.
Well, I don't think I understand git-lfs well enough to know how that error fixed itself. I only deleted the old PR branch and cleaned up my local git caches. 🤷🏼♀️ However, I did try re-running the optional-dependencies CI, and it seems to pass consistently now. |
Ok, the reason that only the optional dependencies job is failing is because it is the only one which uses a ragna/.github/workflows/lint.yml Lines 27 to 30 in b7c5cff
Still trying to figure out why the error happens though. |
Ok, I can reproduce the issue when checking out Ragna on a system that doesn't have |
*.gif filter=lfs diff=lfs merge=lfs -text | ||
*.png filter=lfs diff=lfs merge=lfs -text | ||
# but keep the brand images as regular images | ||
docs/assets/brand/logo-**/* !filter !diff !merge binary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pavithraes Found the issue. You reset the type to text
here, which led to the files being compared as text although they are binaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pavithraes!
Supersedes #300
Fixes #247
Ref: https://git-lfs.com