This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Red Queen CLI #27
base: main
Are you sure you want to change the base?
Adding Red Queen CLI #27
Changes from 22 commits
b01544a
52312ff
b79e630
2b1d01a
16c5a8b
5758d09
3e8105f
05d176a
c881705
19b496a
52274a0
acd8d71
e404a26
cf4ecd0
422815d
279e6f7
3c808d7
3ff1047
79cb6db
9d7d71a
f41069d
6e77b84
d734d76
454dbfa
1e2e944
65fb8cf
af682a4
c39b862
a5f7e8d
d9c01c8
7263118
a9ed1ac
fb57d04
f7f61a3
b410c0f
279549f
d310cdc
10fafa2
d4fb6a1
4c0965f
16ca108
8531c98
08eef59
c9ec3cf
63fa321
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does using explicit html markup for headers and breaks improve the formatting here? I think we should stick to the markdown formatting if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking into it, and it doesn't really add much. The Web Dev in me wanted it to make sense, but it doesn't. I'll adjust it accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't really need to say this as it's a standard convention on unix systems for interpreted programs.
Instead you should have a module docstring that describes the purpose of the python code in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I just pushed a docstring that is more descriptive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should be able to call this directly via python. It looks like I forgot to move the
report
directory intored_queen
as part of #21 which precludes doing this now. So this is fine for now. But after this merges we should move the report stuff into the red queen package and then basically make this function something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If anything, once we get the CLI merged, open that as an issue. And then, I'll try my best to address it in a timely manor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be commented? I assume if you call this file standalone you want it to run the CLI too:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I was testing out code and forgot comment back in
main()
.