-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSLContext arg to aiohttp adapter #483
Conversation
Pass an SSLContext to the aiohttp adapter to create a valid SSL endpoint for OAuth callback.
Please see the type coverage issues and the contribution agreement in the checklist. It should also be considered to add the equivalent to startlette_adapter to maintain parity. |
I agreed to the contribution agreement. The starlette_adapter should also get the same pass through but I'm unfamiliar with starlette and would have to do some research. I also added the suggested help text from @EvieePy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the text to reflect what you suggested.
Moved the ssl import to TYPE_CHECKING section.
…itchIO into ssl_context_argument
Thanks LGTM 👍 |
Pass an SSLContext to the aiohttp adapter to create a valid SSL endpoint for OAuth callback.
Description
I needed the built-in
aiohttp
adapter to provide an SSL configuration so I could do OAuth with a callback without proxying my traffic through nginx. This can be done by passing anSSLContext
object to the constructor ofweb.TCPSite
.Checklist