-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link #130
Fix link #130
Conversation
WalkthroughThe pull request updates a localization file and adjusts HTML message processing. In the localization file, a translation string has been modified to use Markdown-style linking instead of an HTML anchor. In the HTML presenter class, the methods for rendering intro and footer messages have been updated—using parsing for the introduction and escaping for the footer—to change how message content is prepared for HTML output. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Presenter as HtmlPredicatesPresenter
participant Message
Client->>Presenter: call createIntro()
Presenter->>Message: retrieve intro message
Message-->>Presenter: return raw intro message
Presenter->>Presenter: process message with parse()
Presenter-->>Client: return parsed intro HTML
Client->>Presenter: call createFooter()
Presenter->>Message: retrieve footer message
Message-->>Presenter: return raw footer message
Presenter->>Presenter: process message with escaped()
Presenter-->>Client: return escaped footer HTML
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 PHPStan (2.0.3)/bin/bash: line 1: /vendor/bin/phpstan: No such file or directory 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Reported at https://phabricator.wikimedia.org/T386183
53a53a0
to
d748076
Compare
I confirmed with a manual test. |
Reported at https://phabricator.wikimedia.org/T386183
I did not manually test this
Summary by CodeRabbit