Fixed tests and added composer script for phpstan

PrestaShopCorp · Feb 4, 2025 · 7fe935a · 7fe935a
1 parent 57d26ef
commit 7fe935a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/composer.json b/composer.json
@@ -74,6 +74,10 @@
         ],
         "auto-index": [
             "@php ./vendor/bin/autoindex --exclude=_dev,vendor,tests"
+        ],
+        "phpstan": [
+            "@putenv _PS_ROOT_DIR_=../../.",
+            "@php phpstan analyse -c tests/phpstan/phpstan.neon"
         ]
     },
     "author": "PrestaShop"

diff --git a/src/Builder/Payload/OrderPayloadBuilder.php b/src/Builder/Payload/OrderPayloadBuilder.php
@@ -60,11 +60,6 @@ class OrderPayloadBuilder extends Builder implements PayloadBuilderInterface
      */
     private $paypalOrderId;
 
-    /**
-     * @var bool
-     */
-    private $isPatch;
-
     /**
      * @var bool
      */
@@ -137,12 +132,10 @@ public function setVault($vault)
 
     /**
      * @param array $cart
-     * @param bool $isPatch
      */
-    public function __construct(array $cart, $isPatch = false)
+    public function __construct(array $cart)
     {
         $this->cart = $cart;
-        $this->isPatch = $isPatch;
 
         parent::__construct();
     }

diff --git a/src/PayPal/Order/CommandHandler/UpdatePayPalOrderCommandHandler.php b/src/PayPal/Order/CommandHandler/UpdatePayPalOrderCommandHandler.php
@@ -63,7 +63,7 @@ public function __invoke(UpdatePayPalOrderCommand $command)
         }
 
         $cartPresenter = (new CartPresenter())->present();
-        $builder = new OrderPayloadBuilder($cartPresenter, true);
+        $builder = new OrderPayloadBuilder($cartPresenter);
         $builder->setIsUpdate(true);
         $builder->setPaypalOrderId($command->getPayPalOrderId()->getValue());
         $builder->setIsCard($command->getFundingSource() === 'card' && $command->isHostedFields());

diff --git a/tests/Unit/PaypalCountryCodeMatriceTest.php b/tests/Unit/PaypalCountryCodeMatriceTest.php
@@ -17,6 +17,9 @@
  * @copyright Since 2007 PrestaShop SA and Contributors
  * @license   https://opensource.org/licenses/AFL-3.0 Academic Free License 3.0 (AFL-3.0)
  */
+
+namespace Tests\Unit;
+
 use PHPUnit\Framework\TestCase;
 use PrestaShop\Module\PrestashopCheckout\PaypalCountryCodeMatrice;