Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdnsutil] Heed default-soa-edit in create-zone #15197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miodvallat
Copy link
Contributor

Short description

This addresses #8785 by applying the default-soa-edit recipe to the freshly created zone serial number, unless default-soa-content contains a non-zero serial number.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

(unless default-soa-content specifies a nonzero serial number)

Fixes: 8785
@coveralls
Copy link

coveralls commented Feb 21, 2025

Pull Request Test Coverage Report for Build 13454356842

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1792 unchanged lines in 62 files lost coverage.
  • Overall coverage decreased (-0.02%) to 64.494%

Files with Coverage Reduction New Missed Lines %
modules/godbcbackend/sodbc.cc 1 70.8%
pdns/dnsdistdist/dnsdist-backend.cc 1 66.19%
pdns/recursordist/recursor_cache.cc 1 84.29%
pdns/validate.cc 1 68.33%
ext/json11/json11.cpp 2 62.72%
ext/yahttp/yahttp/reqresp.hpp 2 62.72%
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
pdns/cachecleaner.hh 2 79.79%
pdns/dnstap.cc 2 70.97%
pdns/lock.hh 2 84.71%
Totals Coverage Status
Change from base Build 13454033970: -0.02%
Covered Lines: 127632
Relevant Lines: 166902

💛 - Coveralls

@mind04
Copy link
Contributor

mind04 commented Feb 21, 2025

Too much complexity for my taste. Every time you add magic like this to pdnsutil it is loosing some of it's superpowers.
If you want this behaviour today just execute-create zone and increase-serial after an other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants