feat: 🎸 CorporateBallots #1459
Open
feat: 🎸 CorporateBallots #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantasdeveloper
requested changes
Apr 1, 2025
|
Also, you need to rebase the entire PR once on top of develop branch |
sansan
force-pushed
the
feat/DA-1469
branch
3 times, most recently
from
944a762 to
d770a63
Compare
prashantasdeveloper
requested changes
Apr 14, 2025
sansan
force-pushed
the
feat/DA-1469
branch
3 times, most recently
from
f5aca3d to
29720e5
Compare
prashantasdeveloper
previously approved these changes
Apr 30, 2025
sansan
force-pushed
the
feat/DA-1469
branch
2 times, most recently
from
69579a4 to
7e2ca53
Compare
| /** | ||
| * Retrieve all Ballots associated to this Asset | ||
| */ | ||
| public async get(): Promise<CorporateBallotWithDetails[]> { |
There was a problem hiding this comment.
This should accept optional pagination params
There was a problem hiding this comment.
don't think we can use it here - we need to get all of the corporate actions to be able to filter out the ballot type and then request details - so can't use pagination on that one
so if we'd add pagination we could then request details only for the paged entries or we'd ned to use sq to replace the first one..
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
JIRA Link
Checklist