Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installer to use locals, and fs functions #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SkyTheCodeMaster
Copy link

This PR:

  • Localizes every variable
  • Removes the use of io.open to check if a file exists, and instead uses fs.exists
  • Changes instances of if expr==false then to if not expr then

@PentagonLP
Copy link
Owner

Hi! First of all, thank you for your contribution.
I can't just merge your pull request, because all the file functions and all the http functions do now have their own library (https://github.com/PentagonLP/fileutils and https://github.com/PentagonLP/httputils), but their code is still copy-pasted in this file because "pastebin run" does only allow one file to be downloaded. Your changes will be made there and then be manually merged back into the installer.
Also, the installer has been modified for the new upcoming ccpt version (https://github.com/PentagonLP/ccpt/blob/DevVersion-1.1/ccptinstall.lua), but it inherited many of the issues of the old one. Your changes will be made in the over there.
I'm a bit short of time rn, but this pull request will be left open until your changes are implemented, so that I don't forget :)
Again, thank you for contributing!
~PentagonLP

PentagonLP pushed a commit to PentagonLP/fileutils that referenced this pull request Aug 18, 2021
Thanks SkyTheCodeMaster!
PentagonLP pushed a commit to PentagonLP/httputils that referenced this pull request Aug 18, 2021
Thanks SkyTheCodeMaster!
PentagonLP pushed a commit that referenced this pull request Aug 18, 2021
Thanks SkyTheCodeMaster!
@PentagonLP
Copy link
Owner

Code is now implemented, will do some tesing tomorrow before closing the pull request.

PentagonLP added a commit to PentagonLP/fileutils that referenced this pull request Mar 11, 2023
Thanks SkyTheCodeMaster!
PentagonLP added a commit to PentagonLP/fileutils that referenced this pull request Mar 11, 2023
Thanks SkyTheCodeMaster!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants