Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new media sizes; adjusted sizes for menuLink, underline, and se… #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Six5pAdes
Copy link

@Six5pAdes Six5pAdes commented Feb 14, 2025

…archbar length

Description

This PR attempts to respond to the issue of the navbar's CSS.

Changes include:

  • Adding more media rules for other screen sizes
  • Changing sizes of the navLinks and logo so they fit the mobile sizes
  • Adjusting the searchbar width to make it more responsive according to the screen size
    - removing some whitespace between searchbar and navLinks

Motivation

My motivation was to make the navbar and its elements more responsive in accordance with however big the screen and/or the page were.


Type of Change

  • 🆕 New Feature
  • 🐛 Bug Fix
  • 🖼 Wallpaper Added
  • 🎨 UI/Design Update
  • 🔄 Refactor/Code Improvement
  • 📂 Other (Specify here):

Issue Linked:

Fixes #44


Checklist

  • 📖 I have read and followed the Contributing Guidelines.
  • ✅ My code adheres to the project's style guidelines.
  • 🧪 I have tested my changes locally and ensured no existing functionality is broken.
  • ✍️ I have added or updated necessary documentation where applicable (e.g., README.md, DESIGN.md, WALLPAPER.md).

Video Submission

Fix.Navbar.Responsiveness.and.Design.Mismatch.44.mov

Additional Notes

The searchbar itself still needs to be fixed so the whitespace is similar to the original Figma images. On that note, I do believe what is written in this PR is a step in the right direction.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks @Six5pAdes for your PR! A maintainer will review it shortly. We appreciate your contribution!

@Parnab03
Copy link
Owner

@Six5pAdes
First, ensure that your pull request includes proper and detailed information about the changes or features you're proposing. Additionally, we are not requesting the implementation of such features or changes as you’ve described. Please join our Discord server and showcase your work there first before proceeding further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🌱 Fix Navbar Responsiveness and Design Mismatch
2 participants