Add loading bar to sapling params download #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
It doesn't seem to move for me (Firefox, MacOS, Netlify build). The bar started at around 5% (visible in video), however, it stayed there for the entirety of the download, only zipping to 100% instantly after about 2 minutes of waiting, then moving on to the Tx creation. Ideally, we want this to be as granular as possible, like our Shield Sync or minimally Tx Creation (which, although less granular, is still very capable of keeping the user updated and remove the "stuck" feeling). Screen.Recording.2025-01-02.at.3.11.14.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Add loading bar to sapling params download.
This uses the prerelease of pivx shield v1.2.0-1, which has been published using the github artifacts of PIVX-Labs/pivx-shield#97
Testing
Closes #509