Add github and docs links to Explorer nav #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliemcgrady
force-pushed
the
nav-improvements
branch
from
9980711 to
a439afe
Compare
Bonkles
requested changes
Dec 13, 2024
site/src/nav/Header.jsx
Outdated
|
|
||
| export default function Header({ zoom, mode, setMode, setZoom }) { | ||
| return ( | ||
| <nav aria-label="Main" className="navbar navbar--fixed-top"> | ||
| <div className="navbar__inner"> | ||
| <div className="navbar__items"> | ||
| <OvertureWordmark /> | ||
| <a | ||
| aria-current="page" | ||
| class="navbar__item navbar__link" |
There was a problem hiding this comment.
Oh man, this is the most minor issue but class should be className. The react code still renders with the proper classes applied, but this quiets a warning from react.
Suggested change
| class="navbar__item navbar__link" | |
| className="navbar__item navbar__link" |
charliemcgrady
force-pushed
the
nav-improvements
branch
from
a439afe to
99506af
Compare
charliemcgrady
force-pushed
the
nav-improvements
branch
from
99506af to
7844474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updating Explorer site to add links as requested in https://github.com/OvertureMaps/tf-developer-advocacy/issues/223. Styling has been kept consistent with navbar at docs.overturemaps.org.
Changes:
Link to changes: https://explore.overturemaps.org/nav-improvements
Example screenshot of startup box and nav links after this change:
