Fix an issue that was causing the current selected themes to become d… #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esynced after the navigator was used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…esynced after the navigator was used.
When any of the navigator options are clicked, such as 'Paris Roads', the site updates the current visible types with a call to a hook named 'setVisibleTypes' that accepts a list of type names to 'check' in the theme selector.
The theme selector was missing the logic that would in turn update the current themes that should be considered 'enabled', which led all of them to still be set as 'ON' even though they weren't checked.
So, after clicking paris roads, the 'Addresses' checkbox would be unchecked, but the 'visibleThemes' would have 'Addresses = True'. This is what caused the need to click the checkbox twice afterwards- the first time toggled true to false, the second time toggled back from false to true, checking the box.