Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiplayer menu #346

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Add multiplayer menu #346

merged 1 commit into from
Feb 7, 2025

Conversation

Nemrav
Copy link
Contributor

@Nemrav Nemrav commented Jan 13, 2025

Adds an initial MP menu consisting of a direct connection tab and a host tab.

  • Entries made in the direct connection tab are saved in plain text to a config file ips.cfg (this could change if we add accounts).
  • When the player clicks to join a game, the entered IP is validated, a password entry prompt is shown, and a dummy error popup is shown.
  • No actual networking functionality. There are a couple functions defined which for now print the player name, password, and entered ip where this should be added later.

@Nemrav Nemrav added the enhancement New feature or request label Jan 13, 2025
@Nemrav Nemrav force-pushed the mp_menu branch 2 times, most recently from b2e09b5 to a88ca89 Compare January 14, 2025 14:40
@Nemrav Nemrav marked this pull request as ready for review January 14, 2025 14:49
@Spartan322
Copy link
Member

Could you also capitalize Add in the commit message?

@Nemrav Nemrav force-pushed the mp_menu branch 2 times, most recently from 7e496f9 to 3ff2973 Compare January 15, 2025 00:07
@Spartan322 Spartan322 changed the title add multiplayer menu Add multiplayer menu Jan 15, 2025
Copy link
Contributor

@Hop311 Hop311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR!
Spartan's explicit type comments, while correct (we should always use explicit types in GDScript, even just Variant when we want to allow something to be multiple types), have resulting in some things breaking. Please test this yourself by deleting (or renaming, if you want to save it for later) your ips config file at %APPDATA%/OpenVic to run the game as a first time MP user

game/src/Game/Menu/MultiplayerMenu/MultiplayerMenu.gd Outdated Show resolved Hide resolved
game/src/Game/Menu/MultiplayerMenu/MultiplayerMenu.gd Outdated Show resolved Hide resolved
game/src/Game/Autoload/Events/Multiplayer.gd Show resolved Hide resolved
@Nemrav Nemrav force-pushed the mp_menu branch 2 times, most recently from 376f354 to ab65b26 Compare February 5, 2025 21:24
@Hop311 Hop311 merged commit 32661bd into master Feb 7, 2025
20 checks passed
@Hop311 Hop311 deleted the mp_menu branch February 7, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants