Fix issues reported by OpenScanHub #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other parts of the code uses bigger array for the same use case, fix the issue by matching the array size to max possible length read by sscanf().
The array members are strings, so we can get correct number of times by dividing the array size by char* size. debug.c: Protect against possible format string attack ppd-collection.cxx: Use intmax_t for printing time_t var
tillkamppeter
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
static analyzer OpenScanHub found several issues when ran on libppd - possible buffer overflows, uninitialized memory, format string issues and resource leaks.
The Pr fixes the current important issues and passes sanity testing.
Would you mind adding them to the project?