Update render from styles when style changes in owner

OpenPonk · Nov 13, 2024 · e6e7f1e · e6e7f1e
1 parent 7ce6832
commit e6e7f1e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 13 deletions.
diff --git a/repository/OpenPonk-Core/OPDiagram.class.st b/repository/OpenPonk-Core/OPDiagram.class.st
@@ -19,7 +19,7 @@ OPDiagram class >> stonAllInstVarNames [
 	^ super stonAllInstVarNames , #( #name #documentation #resolution )
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'accessing' }
 OPDiagram >> canvas: aCanvas [
 
 	self isRendered ifTrue: [
@@ -44,7 +44,7 @@ OPDiagram >> documentation: anObject [
 	documentation := anObject
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'testing' }
 OPDiagram >> isPositionableByUser [
 
 	^ false
@@ -56,21 +56,21 @@ OPDiagram >> isRendered [
 	^ roassalShape isNotNil
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'testing' }
 OPDiagram >> isResizableByUser [
 
 	^ false
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'accessing' }
 OPDiagram >> modelElementName [
 
 	^ (self modelElement respondsTo: #name)
 		  ifTrue: [ self modelElement name ]
 		  ifFalse: [ self modelElementType ]
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'accessing' }
 OPDiagram >> modelElementType [
 
 	^ self modelElement className
@@ -130,7 +130,7 @@ OPDiagram >> resolution: anObject [
 	resolution := anObject
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'rendering' }
 OPDiagram >> updateFromRender [
 
 	self bounds: (OPNodeBounds

diff --git a/repository/OpenPonk-Core/OPDiagramElement.class.st b/repository/OpenPonk-Core/OPDiagramElement.class.st
@@ -139,22 +139,22 @@ OPDiagramElement >> addSelectionDraggableInteraction [
 	roassalShape @ OPRSSelectionDraggable
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'rendering' }
 OPDiagramElement >> addedByMouseClickTo: aPoint [
 
 	"Do nothing by default. The given point is position where user clicked by mouse in order to create the element. If the shape was not added by a mouse click, this method is not called. May be overriden to translate to that position or react in any other way."
 
 
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'enumerating' }
 OPDiagramElement >> allOwnedShapesPositionableByUser [
 
 	self isRendered ifFalse: [ ^ #(  ) ].
 	^ self ownedElements flatCollect: #allOwnedShapesPositionableByUser
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'enumerating' }
 OPDiagramElement >> allShapesPositionableByUser [
 
 	^ self topMostOwningElement allOwnedShapesPositionableByUser
@@ -510,7 +510,7 @@ OPDiagramElement >> roassalShape [
 	^ roassalShape
 ]
 
-{ #category : 'as yet unclassified' }
+{ #category : 'rendering' }
 OPDiagramElement >> roassalShapeUnsubscribe: aSubscriber [
 
 	roassalShape ifNil: [ ^ self ].
@@ -705,7 +705,5 @@ OPDiagramElement >> updateRenderFromSelf [
 { #category : 'initialization' }
 OPDiagramElement >> updateRenderFromStyles [
 
-	"do nothing by default"
-
-
+	self ownedElements select: #isRendered thenDo: #updateRenderFromStyles
 ]