-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.10 from CI, add SPEC0 badge #359
Conversation
@@ -27,7 +27,6 @@ jobs: | |||
matrix: | |||
os: ['ubuntu'] | |||
python-version: | |||
- "3.10" | |||
- "3.11" | |||
- "3.12" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to add 3.13 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can! I believe the openfe
stack doesn't support 3.13 yet (due to ambertools
IIRC), so it might just fail systematically.
Getting the following when trying to test against Python 3.13: https://github.com/OpenFreeEnergy/alchemiscale/actions/runs/13317902605/job/37196314556?pr=359#step:3:35
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
- Coverage 80.52% 80.49% -0.03%
==========================================
Files 27 27
Lines 3743 3743
==========================================
- Hits 3014 3013 -1
- Misses 729 730 +1 ☔ View full report in Codecov by Sentry. |
Trying 3.13 for openmmff here: openmm/openmmforcefields#362 |
@dotsdl unfortunately no py3.13 for openfe for a while to go. We're blocked by a couple of upstream dependencies, one of which I'm in charge of but haven't been able to find the time to deal with it. |
Closes #353.