Eliminate script zombies. Fix python output thread. Default CI to empty string #1903
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1903 +/- ##
==========================================
+ Coverage 79.42% 79.44% +0.01%
==========================================
Files 523 523
Lines 40926 40927 +1
==========================================
+ Hits 32506 32514 +8
+ Misses 8420 8413 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
| @@ -396,6 +396,7 @@ def self.spawn(scope, name, suite_runner = nil, disconnect = false, environment | |||
| process.environment['RUBYOPT'] = nil # Removes loading bundler setup | |||
| process.environment['OPENC3_SCOPE'] = scope | |||
|
|
|||
| process.detach = true | |||
There was a problem hiding this comment.
This prevents zombie processes?
There was a problem hiding this comment.
Yes. Detaching means that the spawning process is not responsible for waiting for the child to die and check the exit status.
| @@ -1223,7 +1225,7 @@ def output_thread_body(self): | |||
| while True: | |||
| if RunningScript.cancel_output: | |||
| break | |||
| if (time.time() - self.output_time) > 5.0: | |||
| if (time.time() - self.output_time_value) > 5.0: | |||
There was a problem hiding this comment.
Did my refactor break this or was it always broke?
closes #1503