Address SonarQube issues #1899
Address SonarQube issues #1899
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
+ Coverage 79.42% 79.45% +0.03%
==========================================
Files 523 523
Lines 40926 40927 +1
==========================================
+ Hits 32506 32520 +14
+ Misses 8420 8407 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| <img | ||
| src={`${siteConfig.baseUrl}img/black_logo.svg`} | ||
| width="400px" | ||
| alt="OpenC3" |
There was a problem hiding this comment.
Everything here is formatting except for the addition of the alt tag
| class Screen < OpenC3::TargetFile | ||
| def self.destroy(scope, target, screen) | ||
| # Override Screen.destroy to do nothing |
There was a problem hiding this comment.
It doesn't like a method without anything ... so I moved all the comments to inside the methods
| ) | ||
| await this.exec('inject_tlm', [target_name, packet_name, item_hash], { | ||
| type: value_type, | ||
| }) |
There was a problem hiding this comment.
Not sure what this extra datais or how it even worked without being declared but I removed it
| @@ -87,6 +87,7 @@ export default { | |||
| this.editor.setOptions({ | |||
| useWorker: false, | |||
| }) | |||
| break | |||
| @@ -26,8 +26,7 @@ | |||
|
|
|||
| <script> | |||
| import { AstroStatuses, UnknownToAstroStatus } from '.' | |||
| import dark from '/icons/status-dark.png' | |||
| import light from '/icons/status-light.png' | |||
| import dark from '../../public/icons/status-dark.png' | |||
There was a problem hiding this comment.
Not sure how this ever worked but SonarQube doesn't like absolute paths
| @@ -59,6 +59,7 @@ export default { | |||
| reduced: setting[5] || 'DECOM', | |||
| reducedType: setting[6] || null, | |||
| }) | |||
| break | |||
|
No description provided.