Add Generic Cmd Response Protocol and Template Accessor #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
+ Coverage 75.28% 75.33% +0.04%
==========================================
Files 588 590 +2
Lines 42990 43114 +124
Branches 749 749
==========================================
+ Hits 32367 32481 +114
- Misses 10545 10555 +10
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jmthomas
approved these changes
Jan 8, 2024
| begin | ||
| @write_block_queue.pop(true) while @write_block_queue.length > 0 | ||
| rescue | ||
| end |
There was a problem hiding this comment.
Do you maybe just want a @write_block_queue.clear
|
|
||
| module OpenC3 | ||
| class TemplateAccessor < Accessor | ||
| def initialize(packet, left_char = '<', right_char = '>') |
There was a problem hiding this comment.
So default delimiters are <value> but you also have code to make (value) work. I assume any other non-regex sensitive value like #value# works?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.