Skip to content

Commit

Permalink
Address CICD issues
Browse files Browse the repository at this point in the history
  • Loading branch information
ryanmelt committed Nov 28, 2024
1 parent d379d5b commit 6f4e56b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/spelling.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
name: Codespell
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: codespell-project/actions-codespell@v2
with:
# Skip generated code as well as cstol_converter which has false
# positivies on ADN and Adn
skip: ./docs,*.map,*.min.js,*.pem,*.bin,cstol_converter
ignore_words_file: .whitelist
- uses: actions/checkout@v4
- uses: codespell-project/actions-codespell@v2
with:
# Skip generated code as well as cstol_converter which has false
# positivies on ADN and Adn
skip: ./docs,*.map,*.min.js,*.pem,*.bin,cstol_converter,vue.global.*,vuetify-labs*
ignore_words_file: .whitelist
2 changes: 2 additions & 0 deletions openc3-cosmos-init/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ RUN ["/openc3/plugins/docker-package-build.sh", "openc3-cosmos-tool-docs"]

FROM ${OPENC3_REGISTRY}/${OPENC3_NAMESPACE}/${OPENC3_BASE_IMAGE}:${OPENC3_TAG}

USER ${USER_ID}:${GROUP_ID}

COPY --from=openc3-tmp1 --chown=${IMAGE_USER}:${IMAGE_GROUP} /openc3/plugins/packages/openc3-cosmos-ace-diff/ /openc3/plugins/packages/openc3-cosmos-ace-diff/
COPY --from=openc3-tmp1 --chown=${IMAGE_USER}:${IMAGE_GROUP} /openc3/plugins/gems/* /openc3/plugins/gems/
COPY --from=openc3-tmp2 --chown=${IMAGE_USER}:${IMAGE_GROUP} /openc3/plugins/gems/* /openc3/plugins/gems/
Expand Down
4 changes: 2 additions & 2 deletions playwright/tests/wait-for-build.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ test('waits for the services to deploy and connect', async ({
await expect(page.locator('.v-app-bar')).toContainText('CmdTlmServer')
// Check the 3rd column (nth starts at 0) on the row containing INST_INT says CONNECTED
await expect(
page.locator('tr:has-text("INST_INT") td >> nth=2'),
page.locator('[data-test="interfaces-table"]').locator('tr:has-text("INST_INT") td >> nth=2'),
).toContainText('CONNECTED', {
timeout: 120000,
})
await expect(
page.locator('tr:has-text("INST2_INT") td >> nth=2'),
page.locator('[data-test="interfaces-table"]').locator('tr:has-text("INST2_INT") td >> nth=2'),
).toContainText('CONNECTED', {

Check failure on line 37 in playwright/tests/wait-for-build.spec.ts

View workflow job for this annotation

GitHub Actions / openc3-build-test

[chromium] › wait-for-build.spec.ts:23:5 › waits for the services to deploy and connect

1) [chromium] › wait-for-build.spec.ts:23:5 › waits for the services to deploy and connect ─────── Error: Timed out 60000ms waiting for expect(locator).toContainText(expected) Locator: locator('[data-test="interfaces-table"]').locator('tr:has-text("INST2_INT") td').nth(2) Expected string: "CONNECTED" Received: <element(s) not found> Call log: - expect.toContainText with timeout 60000ms - waiting for locator('[data-test="interfaces-table"]').locator('tr:has-text("INST2_INT") td').nth(2) 35 | await expect( 36 | page.locator('[data-test="interfaces-table"]').locator('tr:has-text("INST2_INT") td >> nth=2'), > 37 | ).toContainText('CONNECTED', { | ^ 38 | timeout: 60000, 39 | }) 40 | }) at /home/runner/work/cosmos/cosmos/playwright/tests/wait-for-build.spec.ts:37:5

Check failure on line 37 in playwright/tests/wait-for-build.spec.ts

View workflow job for this annotation

GitHub Actions / openc3-build-test

[chromium] › wait-for-build.spec.ts:23:5 › waits for the services to deploy and connect

1) [chromium] › wait-for-build.spec.ts:23:5 › waits for the services to deploy and connect ─────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 60000ms waiting for expect(locator).toContainText(expected) Locator: locator('[data-test="interfaces-table"]').locator('tr:has-text("INST2_INT") td').nth(2) Expected string: "CONNECTED" Received: <element(s) not found> Call log: - expect.toContainText with timeout 60000ms - waiting for locator('[data-test="interfaces-table"]').locator('tr:has-text("INST2_INT") td').nth(2) 35 | await expect( 36 | page.locator('[data-test="interfaces-table"]').locator('tr:has-text("INST2_INT") td >> nth=2'), > 37 | ).toContainText('CONNECTED', { | ^ 38 | timeout: 60000, 39 | }) 40 | }) at /home/runner/work/cosmos/cosmos/playwright/tests/wait-for-build.spec.ts:37:5
timeout: 60000,
})
Expand Down

0 comments on commit 6f4e56b

Please sign in to comment.