Enqueue Convergence Output Only if Needed #6086
Conversation
|
I'm creating this PR in draft mode because it depends on, and contains, the earlier PR #6085. I will keep the PR in a draft state until such time as it is ready for review. |
bska
force-pushed
the
skip-empty-convergence-reports
branch
5 times, most recently
from
3e6de90 to
055b581
Compare
The earlier PR was merged into the master branch. I'm marking this PR as "ready for review" and I'm running a build check. |
|
jenkins build this please |
bska
force-pushed
the
skip-empty-convergence-reports
branch
from
055b581 to
faeb624
Compare
|
jenkins build this please |
bska
force-pushed
the
skip-empty-convergence-reports
branch
from
faeb624 to
bb26314
Compare
I suppose we can say "we've already written..." instead. Would that be an improvement? |
|
yes i think using written is an improvement. |
bska
force-pushed
the
skip-empty-convergence-reports
branch
from
bb26314 to
5a9b124
Compare
Cool–I've pushed an update to that effect. |
|
jenkins build this please |
| /// Must not be called before startThread() or after endThread(). | ||
| /// | ||
| /// Only those reports which have not previously been emitted will be | ||
| /// output, and only if the run actually requests convergence output at |
There was a problem hiding this comment.
here as well
Right–sorry about that. I've pushed another update to address this.
While here, also add Doxygen style documentation to the data members and member functions of class SimulatorConvergenceOutput.
bska
force-pushed
the
skip-empty-convergence-reports
branch
from
5a9b124 to
b3f9848
Compare
|
jenkins build this please |
|
PR approved and build check is green. I'll merge into master. |
While here, also add Doxygen style documentation to the data members and member functions of class
SimulatorConvergenceOutput.