-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a container for FLOWS data output #5954
Conversation
jenkins build this please |
jenkins build this opm-common=4460 please |
as such, yes. however, there is incoming work in OPM/opm-common#4410 that will affect this. in particular I can simplify this as there is no longer a -1 index for the water phase in the generic fluid system, which means i remove some additional template stuff I had to do to avoid compiler warnings. I think we should wait for that and then I can redo. |
Noted. Thanks a lot for the information. |
e19b0d8
to
9720127
Compare
turns out the component index is still -1 for water, only the phase index changes, so i couldn't really simplify things. but in any case, this is now ready for review. |
jenkins build this please |
19de675
to
2c43e50
Compare
jenkins build this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. I think this is ready for merging once the final tiny issue has been addressed.
2c43e50
to
bea2c0c
Compare
start by taking ownership of related variables and putting initialization code in its ctor
and use this when assigning blockflow
bea2c0c
to
79a1407
Compare
jenkins build this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the updates. This looks good to me now and I'll merge into master.
Sits on top of #5950