libutee: add TEE_ALG_ECDSA_RAW #7250
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove specific management of TEE_ALG_RSASSA_PKCS1_V1_5 in TEE_AllocateOperation() when getting the operation class since TEE_ALG_GET_CLASS() already handle this specific algorithm. By the way, remove few use of TEE_ALG_GET_CLASS() where the algorithm class was already available. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
Add an assertion in __tee_alg_get_class() to ensure all implementation specific algorithm IDs (that shall have the 4 MSBits to 0xF) are specifically handled by the routine and 0xF tag value is not returned to the caller. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
Add GP TEE Internal Core API extension algorithm ID TEE_ALG_ECDSA_RAW for ECDSA signature computation and verification operations when the digest algorithm is not specified. This algorithm ID is supported upon build configuration switch CFG_CRYPTO_ECDSA_NOHASH. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>
etienne-lms
force-pushed
the
ecdsa-nohash
branch
from
cffa154 to
0b8e18f
Compare
| @@ -78,6 +79,9 @@ static inline uint32_t __tee_alg_get_class(uint32_t algo) | |||
| if (algo == TEE_ALG_RSAES_PKCS1_OAEP_MGF1_MD5) | |||
| return TEE_OPERATION_ASYMMETRIC_CIPHER; | |||
|
|
|||
| /* Implementation defined algorithm IDs must be specifically handled */ | |||
| assert(((algo >> 28) & 0xF) != 0xF); | |||
There was a problem hiding this comment.
Can we return __TEE_OPERATION_UNDEFINED (with the value 0) or such instead of asserting?
|
This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note, that you can always re-open a closed issue at any time. |
|
Please keep alive. I'll work back on this topic soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GP TEE Internal Core API extension algorithm ID
TEE_ALG_ECDSA_RAWfor ECDSA signature computation and verification operations when the digest algorithm is not specified. This algorithm ID is supported upon build configuration switchCFG_CRYPTO_ECDSA_NOHASH.