Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update
themes
totopics
Jira - https://jira.ons.gov.uk/browse/DIS-2818
How to review
Local test -
static
dataset - POST request tolocalhost:22000/datasets
, and confirm that validation works by omittingtopics
from request bodytopics
fieldlocalhost:22000/datasets/{dataset-id}
with dataset id from step 1 and confirm thattopics
is included in responselocalhost:22000/datasets/{dataset-id}/editions/time-series/versions
localhost:22000/datasets/{dataset-id}/editions/time-series/versions/{version-number}/metadata
and confirm thattopics
is included in responselocalhost:22000/datasets/{dataset-id}
with an amendedtopics
fieldlocalhost:22000/datasets/{dataset-id}
and confirm the amendedtopics
field is included in responselocalhost:22000/datasets
and confirm the topics field is included in response for any newstatic
datasets created in previous stepsConfirm changes make sense, tests pass
Who can review
Anyone