Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace themes with topics #512

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

andre-urbani
Copy link
Contributor

@andre-urbani andre-urbani commented Mar 12, 2025

What

Update themes to topics
Jira - https://jira.ons.gov.uk/browse/DIS-2818

How to review

Local test -

  1. Create static dataset - POST request to localhost:22000/datasets, and confirm that validation works by omitting topics from request body
  2. Repeat above step but include topics field
  3. Make a GET request to localhost:22000/datasets/{dataset-id} with dataset id from step 1 and confirm that topics is included in response
  4. Make a POST request to localhost:22000/datasets/{dataset-id}/editions/time-series/versions
  5. Make a GET request to localhost:22000/datasets/{dataset-id}/editions/time-series/versions/{version-number}/metadata and confirm that topics is included in response
  6. Make a PUT request to localhost:22000/datasets/{dataset-id} with an amended topics field
  7. Make a GET request to localhost:22000/datasets/{dataset-id} and confirm the amended topics field is included in response
  8. Make a GET request to localhost:22000/datasets and confirm the topics field is included in response for any new static datasets created in previous steps

Confirm changes make sense, tests pass

Who can review

Anyone

@andre-urbani andre-urbani requested a review from a team as a code owner March 12, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant