Adjusted alignment of button within new grid #3502
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SriHV
changed the title
rmccar
reviewed
Feb 20, 2025
| @@ -42,7 +34,7 @@ $button-shadow-size: 3px; | |||
| color: var(--ons-color-text-inverse); | |||
| display: flex; | |||
| align-items: center; | |||
| padding: 0.75rem 1rem; | |||
| padding: 0.875rem 1rem; | |||
There was a problem hiding this comment.
Why was this change made? If I revert it, the button is still on the grid
There was a problem hiding this comment.
Dina told to increase the height of the buttons to fit the 8px grid. I changed padding to increase the height. Small button height is changed from 32 to 36 and large button's height from 52 to 56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-137
As per Dina's suggestion. increased height of the button to sit in the 8px grid
Removed CSS set for IE11 High Contrast mode which adjusted the button size.
How to review this PR
Inspect any of the button examples and check that button's height is rounder
Checklist
This needs to be completed by the person raising the PR.