util: fix -Wshorten-64-to-32 warnings #12633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12633 +/- ##
==========================================
- Coverage 80.77% 80.75% -0.02%
==========================================
Files 932 932
Lines 259286 259314 +28
==========================================
- Hits 209437 209413 -24
- Misses 49849 49901 +52
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24806 |
victorjulien
approved these changes
Feb 20, 2025
| @@ -126,13 +126,11 @@ void BuildCpusetWithCallback(const char *name, ConfNode *node, | |||
| exit(EXIT_FAILURE); | |||
| } | |||
| if (b > max) { | |||
| SCLogError("%s: upper bound (%ld) of cpu set is too high, only %d cpu(s)", name, b, | |||
| SCLogError("%s: upper bound (%d) of cpu set is too high, only %d cpu(s)", name, b, | |||
There was a problem hiding this comment.
%u now that b is uint32_t. Surprising no CI check rejected this.
There was a problem hiding this comment.
So, should I fix that in the next PR tackling other warnings ?
There was a problem hiding this comment.
yeah, staging branch with this PR is running
Merged
|
Merged in #12653, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
Describe changes:
-Wshorten-64-to-32warnings for some files : utilOne commit of #9840
#12624 CI fixed
Still to do afterwards :