Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect: add keywords for LDAPDN - v4 #12620

Closed
wants to merge 5 commits into from

Conversation

AkakiAlice
Copy link
Contributor

@AkakiAlice AkakiAlice commented Feb 19, 2025

Ticket: #7471

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7471

Description:

  • Implement keywords ldap.request.dn and ldap.responses.dn

Changes:

  • Resolve documentation nits
  • Create 2 commits to resolve nits in the LDAP keyword documentation from previous PR

SV_BRANCH=OISF/suricata-verify#2303
Previous PR: #12556

ldap.request.dn matches on LDAPDN from request operations
This keyword maps the following eve fields:
ldap.request.bind_request.name
ldap.request.add_request.entry
ldap.request.search_request.base_object
ldap.request.modify_request.object
ldap.request.del_request.dn
ldap.request.mod_dn_request.entry
ldap.request.compare_request.entry
It is a sticky buffer
Supports prefiltering

Ticket: OISF#7471
ldap.responses.dn matches on LDAPDN from responses operations
This keyword maps the following eve fields:
ldap.responses[].search_result_entry.base_object
ldap.responses[].bind_response.matched_dn
ldap.responses[].search_result_done.matched_dn
ldap.responses[].modify_response.matched_dn
ldap.responses[].add_response.matched_dn
ldap.responses[].del_response.matched_dn
ldap.responses[].mod_dn_response.matched_dn
ldap.responses[].compare_response.matched_dn
ldap.responses[].extended_response.matched_dn
It is a sticky buffer
Supports prefiltering

Ticket: OISF#7471
@AkakiAlice
Copy link
Contributor Author

Comment updated with rebased SV_BRANCH

@inashivb inashivb added the needs rebase Needs rebase to master label Feb 19, 2025
@victorjulien
Copy link
Member

CI is red, any idea why?

@catenacyber
Copy link
Contributor

nit: commits should be doc:

@catenacyber
Copy link
Contributor

catenacyber commented Feb 19, 2025

CI is red, any idea why?

Old SV branch was used

@@ -0,0 +1,94 @@
.\" Man page generated from reStructuredText.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not have added these files

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some git left over and commit to reword ;-)

@AkakiAlice
Copy link
Contributor Author

Replaced by: #12634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase Needs rebase to master
Development

Successfully merging this pull request may close these issues.

4 participants