-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow saving to same SR series #4889
Conversation
feat: improve series labels feat: improve series labels feat: add series date and time to new SR instances refactor: extract dicom date time feat: generalize nextSRSeriesNumber chore: refactor dicom date time
❌ Deploy Preview for ohif-platform-docs failed. Why did it fail? →
|
✅ Deploy Preview for ohif-dev canceled.
|
Bill had a PR for allowing SR to save to the same series, can you see if we need that too? it was long ago |
@sedghi The other PR has been closed and won't be used. Bill asked me to open this new one. |
This new PR is based on the old one, but uses the new ui-next dialog setup, and doesn't do anything weird with loading/display annotations. There is still the ability to load previous versions, but that is an extension of this one. This menu will only appear when saving to a study that already has SRs, and it will default to the old behaviour. |
@dan-rukas Can you please design this? Criteria:
|
Context
Currently, users are unable to save to an existing SR series — each save operation creates a new series. This pull request introduces functionality that allows users to save a new instance to an existing SR series.
The behavior remains consistent with the current loading mechanism: the most recent instance will be the one displayed, as there is still no implemented method for selecting which instance to load. This change simply enables the ability to add additional instances to the same SR series, which mirrors the behavior seen when multiple instances already exist.
Changes & Results
Before:

Can only create new series
After:

Can still create new series
But can also save to a previsouly existing SR series

Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment