Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui(components): Viewport components updated to ui-next with design updates #4886

Merged
merged 26 commits into from
Apr 7, 2025

Conversation

dan-rukas
Copy link
Member

Context

Updates App to use ui-next Viewport components and updated designs to match OHIF design language

Changes & Results

  • Design updates to match ui-next color variables and matched to OHIF design language
  • Usability: Updated input color variable for better readability on all components
  • Fix: Updated ViewportGrid to use color theme variables (instead of hex color)
  • Replaced legacy ui components in App to use ui-next, including: ViewportActionArrows, ViewportActionButton, ViewportActionCorners, and ViewportActionCornersLocations

Testing

Initial testing completed to verify viewports and action buttons function correctly across various OHIF modes using ui-next

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: macOS Sequoia 15.3 (24D60), Apple M4 Pro
  • Node version: 23.7.0
  • Browser: 134.0.6998.89 (Current)

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit a418468
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/67f4382b8b51850008b887a1
😎 Deploy Preview https://deploy-preview-4886--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for ohif-platform-docs failed. Why did it fail? →

Name Link
🔨 Latest commit a418468
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67f4382be345a300080e1972

@sedghi sedghi requested a review from Copilot April 7, 2025 20:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 54 out of 55 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • extensions/cornerstone/src/Viewport/Overlays/ViewportOrientationMarkers.css: Language not supported
Comments suppressed due to low confidence (4)

extensions/cornerstone/src/components/WindowLevelActionMenu/VolumeRenderingQuality.tsx:45

  • The previous implementation applied a custom background gradient for the slider. Please verify that the new Numeric component provides an equivalent visual indication or add custom styling if needed.
<Numeric.Container

extensions/cornerstone/src/components/WindowLevelActionMenu/VolumeLighting.tsx:65

  • The custom background styling (via calculateBackground) for the slider is no longer present; confirm that the new design meets the desired visual feedback for lighting adjustments.
<Numeric.Container

extensions/cornerstone/src/Viewport/OHIFCornerstoneViewport.tsx:108

  • The subtraction value for the scrollbar height was reduced from 40px to 10px. Please ensure this change does not negatively affect the layout or usability across various viewport sizes.
const scrollbarHeight = `${elementRef.current.clientHeight - 10}px`;

extensions/cornerstone-dicom-seg/src/viewports/OHIFCornerstoneSEGViewport.tsx:50

  • [nitpick] If the selectedSegmentObjectIndex is intended to change over time, consider managing it with component state instead of a constant. If it is meant to remain unchanged, no action is required.
const selectedSegmentObjectIndex: number = 0;

Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As we discussed, we'll finalize the scrollbar color and extract it as a Tailwind parameter in the next pull request.

@sedghi sedghi merged commit a8ac297 into OHIF:master Apr 7, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants