-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui(components): Viewport components updated to ui-next with design updates #4886
Conversation
Color for base grid, removed legacy color, applied active rounding, and added top margin for app consistency
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
❌ Deploy Preview for ohif-platform-docs failed. Why did it fail? →
|
No longer pushes the grid a few pixels off the bottom of the window
All changes necessary to extend the scrollbar from top to bottom
…onents to use Numeric component for sliders. Consolidate lighting property handling in VolumeLighting and remove redundant calculations. Update UI structure for better consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 54 out of 55 changed files in this pull request and generated no comments.
Files not reviewed (1)
- extensions/cornerstone/src/Viewport/Overlays/ViewportOrientationMarkers.css: Language not supported
Comments suppressed due to low confidence (4)
extensions/cornerstone/src/components/WindowLevelActionMenu/VolumeRenderingQuality.tsx:45
- The previous implementation applied a custom background gradient for the slider. Please verify that the new Numeric component provides an equivalent visual indication or add custom styling if needed.
<Numeric.Container
extensions/cornerstone/src/components/WindowLevelActionMenu/VolumeLighting.tsx:65
- The custom background styling (via calculateBackground) for the slider is no longer present; confirm that the new design meets the desired visual feedback for lighting adjustments.
<Numeric.Container
extensions/cornerstone/src/Viewport/OHIFCornerstoneViewport.tsx:108
- The subtraction value for the scrollbar height was reduced from 40px to 10px. Please ensure this change does not negatively affect the layout or usability across various viewport sizes.
const scrollbarHeight = `${elementRef.current.clientHeight - 10}px`;
extensions/cornerstone-dicom-seg/src/viewports/OHIFCornerstoneSEGViewport.tsx:50
- [nitpick] If the selectedSegmentObjectIndex is intended to change over time, consider managing it with component state instead of a constant. If it is meant to remain unchanged, no action is required.
const selectedSegmentObjectIndex: number = 0;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! As we discussed, we'll finalize the scrollbar color and extract it as a Tailwind parameter in the next pull request.
Context
Updates App to use
ui-next
Viewport components and updated designs to match OHIF design languageChanges & Results
ui-next
color variables and matched to OHIF design languageViewportGrid
to use color theme variables (instead of hex color)ui-next
, including:ViewportActionArrows
,ViewportActionButton
,ViewportActionCorners
, andViewportActionCornersLocations
Testing
Initial testing completed to verify viewports and action buttons function correctly across various OHIF modes using
ui-next
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment