Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show variable+value pairs in cohort characterization #1147

Open
dimshitc opened this issue Nov 25, 2024 · 1 comment
Open

Show variable+value pairs in cohort characterization #1147

dimshitc opened this issue Nov 25, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dimshitc
Copy link

To reflect full meaning of the measurement, it should be shown with it's value_as_concept_id or if the result is numeric, the value is interpreted based on the reference range with such a values generated: "below", "within" and "above normal range".
Currently the only variables are shown.
The feature extractor already supports the variables with values, it was implemented in FeatureExtraction 3.6.0.

Also, does Compare characterization use the variable+value pairs, or only variables?
image

@azimov
Copy link
Collaborator

azimov commented Nov 26, 2024

Thanks @dimshitc!

The current implementation within CD is to only use the presence or not of a covariate, so this would be a significant enhancement.

How we implement this is probably going to be some extra functionality specific to measurements though but the use of the "Below, within, above" pattern in FE > 3.6.0 might turn out to be fairly striaghtforward.

Also, does Compare characterization use the variable+value pairs, or only variables?

It will only be using variables currently.

I will add this to our release roadmap as as this could be extremely useful!

@azimov azimov self-assigned this Nov 26, 2024
@azimov azimov added the enhancement New feature or request label Nov 26, 2024
@azimov azimov added this to the Release version 4.0.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants