Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feat/data cleanup #60

Merged
merged 45 commits into from
Jan 24, 2024
Merged

WIP: Feat/data cleanup #60

merged 45 commits into from
Jan 24, 2024

Conversation

sanjayankur31
Copy link
Contributor

Please feel free to push to this branch also. What needs to be done is explained in the meeting notes here:

https://hackmd.io/@mstimberg/SJz9WJCST

@sanjayankur31
Copy link
Contributor Author

sanjayankur31 commented Jan 17, 2024

Questions I came up with (so far 😅):

  • "neural mass models" (TVB) -> "Population model?" or should it be a new possibility under "biological_level"?
  • tools can have multiple relations, so should the "description" of relations be a list? (See NEURON, and relationship with NeuroML, for example)
  • consistency in features: should it be "plotting" or "plots" or another form of the word? "can import" or "imports"?
  • model_description_language is also probably not necessary for all tools
  • should standards include the biophysical_level feature (we'd decided only simulators should include these---maybe we should say that simulators must include them, and that other tools may optionally have them where appropriate?)
  • not all relations need to be bidirectional. For example NestML -> NEST: "language for", but NEST -> "NestML": ?? (doesn't make sense to say "can be described by", the graph will show the one sided relationship anyway?)

@sanjayankur31 sanjayankur31 marked this pull request as ready for review January 19, 2024 14:40
@sanjayankur31
Copy link
Contributor Author

Also created a project board: https://github.com/orgs/OCNS/projects/2/views/1 (but only team members can view it, the organization admins will have to change its visibility)

@sanjayankur31
Copy link
Contributor Author

The files are valid, it's the bit that reads them that's failing the tests----because we removed some fields and things.

Copy link
Collaborator

@mstimberg mstimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!
I update the testing script to work with the new data (e.g. most fields are optional, except for tools with the "simulator" feature). I also updated the website to work with the new data, but did not spend the time to actually display the relation descriptions. We'll most likely change the interface in any case. I had a weird issue on my machine and the old version of panel from requirements.txt did no longer work (maybe incompatible with recent Python versions ?), so I updated it to a newer version.

@mstimberg mstimberg merged commit 9b56b7a into main Jan 24, 2024
2 checks passed
@mstimberg mstimberg deleted the feat/data-cleanup branch January 24, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants