-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feat/data cleanup #60
Conversation
- engines should include "simulator" - `computing_scale` -> `processing_support` - add `description` to relations
- not an engine, so bits removed - relationships to simulator engines added
Questions I came up with (so far 😅):
|
has been integrated with NEURON: https://github.com/BlueBrain/CoreNeuron/
Also created a project board: https://github.com/orgs/OCNS/projects/2/views/1 (but only team members can view it, the organization admins will have to change its visibility) |
The files are valid, it's the bit that reads them that's failing the tests----because we removed some fields and things. |
Forgot to install the pre-commit hooks on new install...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
I update the testing script to work with the new data (e.g. most fields are optional, except for tools with the "simulator" feature). I also updated the website to work with the new data, but did not spend the time to actually display the relation descriptions. We'll most likely change the interface in any case. I had a weird issue on my machine and the old version of panel from requirements.txt
did no longer work (maybe incompatible with recent Python versions ?), so I updated it to a newer version.
Please feel free to push to this branch also. What needs to be done is explained in the meeting notes here:
https://hackmd.io/@mstimberg/SJz9WJCST