Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] pim: Migration to 17.0 #194

Open
wants to merge 40 commits into
base: 17.0
Choose a base branch
from
Open

Conversation

clementmbr and others added 30 commits February 6, 2025 21:59
New organization :

- attribute_set (former base_custom_attribute)
- product_attribute_set (former pim_custom_attribute but without menus)
- pim (The "PIM application" former pim_base)
- pim_attrubute_set (depends on product_attribute_set and adds menus in
the PIM application)
attribute_set need 'include_native_attribute' param in context in order to work properly
@kobros-tech
Copy link
Author

@dnplkndll

@dnplkndll
Copy link

UncaughtPromiseError > EvalError
Uncaught Promise > Can not evaluate python expression: ( {"search_default_attribute_group_id": id, "active_attribute_sort": True} ) Error: Name 'id' is not defined

Attribute Groups - Sort attributes on this one too.

@kobros-tech
Copy link
Author

@dnplkndll

The bug is fixed in a commit for PR #190, we can review in OCA boat.

Screencast.2025-02-10.14.46.14.mp4

@kobros-tech
Copy link
Author

kobros-tech commented Feb 19, 2025

In odoo to have your passed in context key to the current view not stripped away when you open another view from current one like wizard for example, you must suffix it with _view_ref.

In case of opening a view from menu item via action it happens too, same as here!

In this list view the sequence field is shown if context key is True, but this key is stripped away since odoo 17.0 unless it is lang or ends with _view_ref

I strongly suggest we write about this in the wiki, @pedrobaeza @dnplkndll

Reference:
https://github.com/odoo/odoo/blob/00818b7bfaf22635b0c40b3b9c7e37e0c9789da1/addons/web/static/src/views/view_service.js#L90

Screenshot from 2025-02-19 13-00-48

@pedrobaeza
Copy link
Member

Not sure to understand the possible change. Can you please redact the possible sentence to add to the migration guide?

@kobros-tech
Copy link
Author

@pedrobaeza
ok I will consult Mr. Don to write a descriptive guiding sentence.

@kobros-tech
Copy link
Author

@wlin-kencove
Could you review this PR and its related dependencies?
They are running here in this PR, I hope you like this version and not find any more issues.

@kobros-tech
Copy link
Author

This module succeeded to run when I patched a fix to odoo code, I will introduce an isuue about that and refer to this PR there.
I will refer to the PR in odoo here to so that we are up to date if the PR gets approved we remove the patch code.

Screencast.2025-02-19.23.24.38.mp4

@kobros-tech
Copy link
Author

Reference to odoo FIX PR that introduced in the patch file:
odoo/odoo#198451

Copy link

@wlin-kencove wlin-kencove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting attributes will remove the fields from the database, which is good. In previous version the field would be removed form the view/model but the x_field was still in the db. This seems like it is resolved.

Only attribute associated with the item's attribute set is displayed in the note which is good. Previously the view was bugged and displayed all attributes even from unrelated attribute sets. This seems to be addressed.

Multi select display seems okay, could probably use a tag widget but this will work as well.
image

@kobros-tech
Copy link
Author

@rousseldenis , @rvalyi

Ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.