-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][ADD] l10n_fr_account_oca: OCA fork of l10n_fr_account #628
base: 18.0
Are you sure you want to change the base?
Conversation
Since v14, OCA/l10n-france has a module l10n_fr_oca which is a fork of l10n_fr. In v18, the chart of accounts was completely reorganized and l10n_fr has been split between l10n_fr and l10n_fr_account. So the best solution was to create a new fork of l10n_fr_account to l10n_fr_account_oca.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,675 @@ | |||
id,name,code,account_type,tag_ids,reconcile | |||
pcg_1011,Capital souscrit - non appelé,101100,equity,,False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. could you avoid to change the format of the file regarding the original one ?
(https://raw.githubusercontent.com/odoo/odoo/refs/heads/18.0/addons/l10n_fr_account/data/template/account.account-fr.csv)
I mean :
- do not change delimiter
- do not remove column
So it is allways easy to compare / meld both files. (the original ones, and the forked one).
thanks !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this specific file account.account-fr_oca.csv, my starting point was NOT the file from l10n_fr_account, but I took the file from OCA/l10n-france/l10n_fr_oca/data/account.account.template.csv v16
As you can see in https://raw.githubusercontent.com/OCA/l10n-france/refs/heads/16.0/l10n_fr_oca/data/account.account.template.csv
the original file doesn't have any quoting ; that's why my file doesn't have quoting.
The delimiter is always coma, so I didn't change the delimiter.
I removed the column name@fr on purpose. In v18, the "name" of account.account is translatable. Translating the account names is quite a difficult task ; instead of having a bad automatic translation certainly full of mistakes, I prefer not to have any translation at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the column name@fr on purpose. In v18, the "name" of account.account is translatable. Translating the account names is quite a difficult task ; instead of having a bad automatic translation certainly full of mistakes, I prefer not to have any translation at all.
Yes, I saw. I think it's legit, and reduce the maintenance time.
For this specific file account.account-fr_oca.csv, my starting point was NOT the file from l10n_fr_account, but I took the file from OCA/l10n-france/l10n_fr_oca/data/account.account.template.csv v16
hum. I see it a little problematic. Is it possible to fork from l10n_fr_account file ? Otherwise, it is just not possible to easily meld both files, so, I don't understand how to maintain the module correctly over time.
Or did I missed something ?
Fix pre-commit + differenciate native and OCA CoA in the configuration list |
18 imp oca coa name
Since v14, OCA/l10n-france has a module l10n_fr_oca which is a fork of l10n_fr.
In v18, the chart of accounts was completely reorganized and l10n_fr has been split between l10n_fr and l10n_fr_account. So the best solution was to create a new fork of l10n_fr_account to l10n_fr_account_oca.