Update Project.toml dependencies

[Laura2305]

No description provided.

[Laura2305]

MRIReco 0.8 gives an error as the new regularization syntax was not implemented yet.
The images are mirrored in the frequency encoding direction when using MRIReco 0.9 compared to 0.7. But the pipeline works. Is this a minor or major version change when released?

[Laura2305]

I've suspended CompatHelper for now.

[Laura2305]

Final version of updated dependencies at current date.

[alexjaffray]

@Laura2305 Looks good to me, thanks for navigating the recent changes in MRIReco.jl.

MRIReco 0.8 gives an error as the new regularization syntax was not implemented yet. The images are mirrored in the frequency encoding direction when using MRIReco 0.9 compared to 0.7. But the pipeline works. Is this a minor or major version change when released?

I would say we should increment to 0.2.0 on release, since if anyone goes to develop (or has modified) the package with their own adjustments, they will have to make additional modifications to adhere to the newer API of MRIReco.jl.

[Laura2305]

@alexjaffray ok great! I think we should wait to merge this PR until Julia 1.11 is released, as Julia 1.9 now is quite a stringent requirement and the current released version of the package works. Once this is merged we can make a new release of the package.

[alexjaffray]

I think so, that would make sense to me. Let's wait to merge once 1.11 releases

[Laura2305]

@alexjaffray Julia 1.11 has been released and the code reviewer are asking to make a release for the main branch, so I'll do that tomorrow.

[alexjaffray]

@Laura2305 Thanks for tackling the reviewer comments, I'm happy to see the feedback. Let me know if you need anything from my side. Regarding this PR, I agree that we should also add 1.11. Do you know what's stopping the nightly run?

[aTrotier]

@alexjaffray it is related to JLD2.
https://github.com/JuliaIO/JLD2.jl/blob/b8b0f9adaff35dbf39e0e4d58c164ff9f278f54b/CHANGELOG.md?plain=1#L10

You should use at least version 0.5.8 if you want to support 1.12

[Laura2305]

JLD2 is not a direct dependency of this package but it is an indirect dependency of Images which is a dependency of this package. It seems like the problem has been solved in the main branch of Images, as its tests passed on nightly, but they haven't made a release yet. I think we should wait for their release.

[alexjaffray]

@Laura2305 there is something larger happening in Images, so I don't think we should wait for Images to release as that may take a very long time. It's been 8 months since the last release... I would consider restricting our Julia compat to 1.11 for now until Images releases a new version, and we should remove the nightly build from the tests (for now). @aTrotier do you agree?

[aTrotier]

Yes, you can add it only when the 1.12 is officially released. Le jeu. 16 janv. 2025, 01:32, Alexander Jaffray ***@***.***> a écrit :

…

@Laura2305 <https://github.com/Laura2305> there is something larger happening in Images, so I don't think we should wait for Images to release as that may take a very long time. It's been 8 months since the last release... I would consider restricting our Julia compat to 1.11 for now until Images releases a new version, and we should remove the nightly build from the tests (for now). @aTrotier <https://github.com/aTrotier> do you agree? — Reply to this email directly, view it on GitHub <#54 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC5P7O3DEFH4J4LMH2T6ZAT2K34ZDAVCNFSM6AAAAABO2RKTZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJUGIYDSNZXGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Laura2305]

Sounds good to me!