perlPackages.NetSNMP: add patch to support modern SHA algorithms for authentication #349861

jwillikers · 2024-10-19T20:38:24Z

The aged perlPackages.NetSNMP library does not support modern SHA authentication protocols such as SHA-256 and SHA-512. It only supports the less secure SHA-1 algorithm. It's possible to enable support for these newer protocols with a patch from the OpenBSD ports tree found here.

References:

Patches used in Linux distributions:

Things done

Add a 👍 reaction to pull requests you find important.

zakame · 2024-10-20T06:35:57Z

Result of nixpkgs-review pr 349861 run on x86_64-linux 1

9 packages built:

fusionInventory
munin
ocsinventory-agent
ocsinventory-agent.devdoc
perl538Packages.NetSNMP
perl538Packages.NetSNMP.devdoc
perl540Packages.NetSNMP
perl540Packages.NetSNMP.devdoc
smokeping

zakame · 2024-10-20T06:39:17Z

Thanks for the patch - checking upstream it appears maintenance is stalled and there are actually a few more suggestions of patches, cf https://rt.cpan.org/Public/Bug/Display.html?id=153907

jwillikers · 2024-10-20T13:42:55Z

Thanks for the patch - checking upstream it appears maintenance is stalled and there are actually a few more suggestions of patches, cf https://rt.cpan.org/Public/Bug/Display.html?id=153907

That's good to hear, I hope it gets updated upstream.

stigtsp · 2024-10-21T15:10:03Z

Hi there!

The patch seems fine to me, but there are some differences between the one vendored in here and the one from OpenBSD ports.

Nothing bad I'm sure, but there are } else { and our $VERSION = v4.0.1; removed in the OpenBSD one that is not removed in this patch.

Index: lib/Net/SNMP/Security/USM.pm			      |	diff --git a/lib/Net/SNMP/Security/USM.pm b/lib/Net/SNMP/Secu
--- lib/Net/SNMP/Security/USM.pm.orig			      |	index 4fb5742..da82212 100644
+++ lib/Net/SNMP/Security/USM.pm			      |	--- a/lib/Net/SNMP/Security/USM.pm
@@ -25,9 +25,10 @@ use Net::SNMP::Message qw(		      |	+++ b/lib/Net/SNMP/Security/USM.pm
							      >	@@ -25,8 +25,9 @@ use Net::SNMP::Message qw(
 							      |	+
+							      |	
 our $VERSION = v4.0.1;					      <
 							      |	+
-   } else {						      <
 							      |	+
+							      |	
+   } else {						      |	    } else {
							      >	-

Generated with:

curl -so /tmp/net-smtp-openbsd.patch https://raw.githubusercontent.com/openbsd/ports/ab6365da3ac861e1c56520acdf388d421b357c17/net/p5-Net-SNMP/patches/patch-lib_Net_SNMP_Security_USM_pm
curl -so /tmp/net-smtp-nixpkgs-pr349861.patch https://raw.githubusercontent.com/NixOS/nixpkgs/fbcd0a2761e960a01eb6dde36a9a26259059c0f5/pkgs/development/perl-modules/net-snmp-enable-newer-sha-algorithms.patch
diff --suppress-common-lines --color=always -y /tmp/net-smtp-openbsd.patch /tmp/net-smtp-nixpkgs-pr349861.patch

jwillikers · 2024-10-21T15:14:58Z

Hi there!

The patch seems fine to me, but there are some differences between the one vendored in here and the one from OpenBSD ports.

Nothing bad I'm sure, but there are } else { and our $VERSION = v4.0.1; removed in the OpenBSD one that is not removed in this patch.

Index: lib/Net/SNMP/Security/USM.pm			      |	diff --git a/lib/Net/SNMP/Security/USM.pm b/lib/Net/SNMP/Secu
--- lib/Net/SNMP/Security/USM.pm.orig			      |	index 4fb5742..da82212 100644
+++ lib/Net/SNMP/Security/USM.pm			      |	--- a/lib/Net/SNMP/Security/USM.pm
@@ -25,9 +25,10 @@ use Net::SNMP::Message qw(		      |	+++ b/lib/Net/SNMP/Security/USM.pm
							      >	@@ -25,8 +25,9 @@ use Net::SNMP::Message qw(
 							      |	+
+							      |	
 our $VERSION = v4.0.1;					      <
 							      |	+
-   } else {						      <
 							      |	+
+							      |	
+   } else {						      |	    } else {
							      >	-

Generated with:

curl -so /tmp/net-smtp-openbsd.patch https://raw.githubusercontent.com/openbsd/ports/ab6365da3ac861e1c56520acdf388d421b357c17/net/p5-Net-SNMP/patches/patch-lib_Net_SNMP_Security_USM_pm
curl -so /tmp/net-smtp-nixpkgs-pr349861.patch https://raw.githubusercontent.com/NixOS/nixpkgs/fbcd0a2761e960a01eb6dde36a9a26259059c0f5/pkgs/development/perl-modules/net-snmp-enable-newer-sha-algorithms.patch
diff --suppress-common-lines --color=always -y /tmp/net-smtp-openbsd.patch /tmp/net-smtp-nixpkgs-pr349861.patch

@stigtsp Thanks for finding that discrepancy. I must have screwed up the patch somehow when I imported it into Git or exported it from Git. I wish I could get fetchpatch to work for the patch, but it was giving me some trouble.

jwillikers · 2024-10-21T15:41:26Z

@stigtsp Okay, I manually doctored the patch to ensure it isn't missing anything this time.

stigtsp · 2024-10-21T15:59:49Z

Looks good to me, maybe add a comment above the patch why it's vendored, including the source URL of the patch?

I can also reproduce problems applying this patch using fetchpatch but vendoring works.

jwillikers · 2024-10-21T16:02:51Z

I can do that. Since the modules used change, the Perl build files need patched as well to ensure the dependencies are correct, right?

jwillikers · 2024-10-23T16:49:33Z

Looks good to me, maybe add a comment above the patch why it's vendored, including the source URL of the patch?

I can also reproduce problems applying this patch using fetchpatch but vendoring works.

@stigtsp I figured out how to use fetchpatch for the patch.

stigtsp · 2024-10-23T17:49:34Z

pkgs/top-level/perl-packages.nix

+    patches = [
+      (fetchpatch {
+        name = "enable-newer-sha-algorithms.patch";
+        url = "https://raw.githubusercontent.com/openbsd/ports/refs/heads/master/net/p5-Net-SNMP/patches/patch-lib_Net_SNMP_Security_USM_pm";


The URL here should be pinned to a commit, maybe:

Suggested change

url = "https://raw.githubusercontent.com/openbsd/ports/refs/heads/master/net/p5-Net-SNMP/patches/patch-lib_Net_SNMP_Security_USM_pm";

url = "https://raw.githubusercontent.com/openbsd/ports/ab6365da3ac861e1c56520acdf388d421b357c17/net/p5-Net-SNMP/patches/patch-lib_Net_SNMP_Security_USM_pm";

Yes of course, my bad.

stigtsp · 2024-10-23T17:50:32Z

pkgs/top-level/perl-packages.nix

+            --replace "--- lib/Net/SNMP/Security/USM.pm.orig" "--- a/lib/Net/SNMP/Security/USM.pm" \
+            --replace "+++ lib/Net/SNMP/Security/USM.pm" "+++ b/lib/Net/SNMP/Security/USM.pm"


This looks like a reasonable solution, consider using --replace-fail so the replace will fail in case it doesn't actually replace anything

Suggested change

--replace "--- lib/Net/SNMP/Security/USM.pm.orig" "--- a/lib/Net/SNMP/Security/USM.pm" \

--replace "+++ lib/Net/SNMP/Security/USM.pm" "+++ b/lib/Net/SNMP/Security/USM.pm"

--replace-fail "--- lib/Net/SNMP/Security/USM.pm.orig" "--- a/lib/Net/SNMP/Security/USM.pm" \

--replace-fail "+++ lib/Net/SNMP/Security/USM.pm" "+++ b/lib/Net/SNMP/Security/USM.pm"

stigtsp

Since the patch is now fetched from github, the vendored one can be removed

stigtsp

The dependencies for Net::SNMP should be updated, DigestHMAC is needed for Digest::HMAC_MD5.

The other additions seem to be required by the failing test suite (although I didn't look at the failing tests in detail).

propagatedBuildInputs = [ CryptDES CryptRijndael DigestHMAC  DigestSHA1 Socket6 ];

jwillikers · 2024-10-23T19:18:00Z

Since the patch is now fetched from github, the vendored one can be removed

I've removed that one now.

jwillikers · 2024-10-23T19:18:39Z

The dependencies for Net::SNMP should be updated, DigestHMAC is needed for Digest::HMAC_MD5.

The other additions seem to be required by the failing test suite (although I didn't look at the failing tests in detail).
propagatedBuildInputs = [ CryptDES CryptRijndael DigestHMAC  DigestSHA1 Socket6 ];

I've added a follow-up patch which corrects the dependencies specified in the project.

stigtsp · 2024-10-24T00:43:14Z

Thanks for the great work! I'm going traveling tomorrow, but will have a look as soon as I can after that.

I'm thinking we might consider looking at getting the tests to pass as well, there was a fork referenced in the RT issue here that could have some interesting patches for that:

https://github.com/michal-josef-spacek/Net-SNMP

What do you think @zakame?

stigtsp · 2024-10-24T00:44:16Z

... also if there are some test for the new algos somewhere, that would also be great so we can make sure this keeps working going forward

jwillikers · 2024-10-24T13:37:18Z

Thanks for the great work! I'm going traveling tomorrow, but will have a look as soon as I can after that.

I'm thinking we might consider looking at getting the tests to pass as well, there was a fork referenced in the RT issue here that could have some interesting patches for that:

https://github.com/michal-josef-spacek/Net-SNMP

What do you think @zakame?

I've got the tests working, just needed to add /etc/protocols since it uses getprotobyname.

... also if there are some test for the new algos somewhere, that would also be great so we can make sure this keeps working going forward

That sounds like a very good idea. I'm working on it.

Safe travels!

jwillikers · 2024-10-24T15:32:18Z

Okay, I've done a couple of things.

I fixed the tests.
I applied the patches from Fedora's package. These are probably the same as https://github.com/michal-josef-spacek/Net-SNMP since Michal Josef Špaček submitted those patches to the Fedora package. There's just a couple less patches in Fedora then there are commits in the repo. These patches correct the dependencies defined in the project so that we don't need to add our own patches to reflect this. These patches also have the benefit of adding more tests.
I adapted the patch https://github.com/openbsd/ports/blob/master/net/p5-Net-SNMP/patches/patch-lib_Net_SNMP_Security_USM_pm to work on top of the Fedora patches.
I included additional tests for each of the new SHA algorithms in the adapted patch.

I've reworked the commits to reflect these changes. Let me know if I should rework or reorder anything. Thanks!

stigtsp · 2024-10-25T13:09:25Z

pkgs/top-level/perl-packages.nix

+      CryptDES
+      CryptRijndael
+      DigestHMAC
+      DigestSHA


DigestSHA is in perl core, so you don't need to list it here

I've dropped DigestSHA.

stigtsp · 2024-10-25T13:13:32Z

This is starting to look pretty good I think, thanks again for the great work on it.

I'd like to review the tests and patches a bit more before merging, will try to get this done tomorrow.

The aged perlPackages.NetSNMP library does not support modern SHA algorithms for authentication. It's possible to enable support for these newer protocols with a patch. The patch is taken from the OpenBSD ports tree: https://github.com/openbsd/ports/blob/master/net/p5-Net-SNMP/patches/patch-lib_Net_SNMP_Security_USM_pm It enables support for SHA 224, 256, 384, and 512. Tests are also include in the patch for these additional algorithms.

zakame · 2024-10-25T17:28:35Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349861

`x86_64-linux`

✅ 11 packages built:

fusionInventory
munin
nagiosPlugins.check_nwc_health
nagiosPlugins.check_ups_health
ocsinventory-agent
ocsinventory-agent.devdoc
perl538Packages.NetSNMP
perl538Packages.NetSNMP.devdoc
perl540Packages.NetSNMP
perl540Packages.NetSNMP.devdoc
smokeping

zakame

LGTM, thanks for the PR! 🎉

stigtsp · 2024-10-26T08:51:29Z

EDIT: This seems to be caused by #351312

Having some issues building this (on several machines), seemingly caused by fetchpatch2.

error: builder for '/nix/store/7sq13pjbsqc10jifq9fzsbjjpkq6c6sz-Net-SNMP-v6.0.1-Rewrite_from_Digest-SHA1-to-Digest-SHA.patch.drv' failed with exit code 1;
       last 9 log lines:
       > error checking the existence of https://tarballs.nixos.org//sha256-dznhj1Fcy0iBBl92p825InjkNZixR2MURVQ/b9bVjtc=:
       > curl: (77) error setting certificate file: /nix/store/h8qhspg7pml84z8s4ghrhmx6m77rs161-nss-cacert-3.104/etc/ssl/certs/ca-bundle.crt
       >
       > trying https://src.fedoraproject.org/rpms/perl-Net-SNMP/raw/6e1d3e8ff2b9bd38dab48301a9d8b5d81ef3b7fe/f/Net-SNMP-v6.0.1-Rewrite_from_Digest-SHA1-to-Digest-SHA.patch
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (77) error setting certificate file: /nix/store/h8qhspg7pml84z8s4ghrhmx6m77rs161-nss-cacert-3.104/etc/ssl/certs/ca-bundle.crt
       > error: cannot download Net-SNMP-v6.0.1-Rewrite_from_Digest-SHA1-to-Digest-SHA.patch from any mirror
       For full logs, run 'nix log /nix/store/7sq13pjbsqc10jifq9fzsbjjpkq6c6sz-Net-SNMP-v6.0.1-Rewrite_from_Digest-SHA1-to-Digest-SHA.patch.drv'.`

Unsure why exactly, but observing that rewriting to using fetchpatch (and updating hashes due to different patch normalization presumably) works:

diff --git a/pkgs/top-level/perl-packages.nix b/pkgs/top-level/perl-packages.nix
index 3b533a10e96b..f7d05cc16c00 100644
--- a/pkgs/top-level/perl-packages.nix
+++ b/pkgs/top-level/perl-packages.nix
@@ -7,7 +7,7 @@

 { config
 , stdenv, lib, buildPackages, pkgs, darwin
-, fetchurl, fetchpatch, fetchpatch2, fetchFromGitHub, fetchFromGitLab
+, fetchurl, fetchpatch, fetchFromGitHub, fetchFromGitLab
 , perl, shortenPerlShebang
 , nixosTests
 }:
@@ -19214,25 +19214,25 @@ with self; {
       hash = "sha256-FMN7wcuz883H1sE+DyeoWfFM3P1epUoEZ6iLwlmwt0E=";
     };
     patches = [
-      (fetchpatch2 {
+      (fetchpatch {
         url = "https://src.fedoraproject.org/rpms/perl-Net-SNMP/raw/6e1d3e8ff2b9bd38dab48301a9d8b5d81ef3b7fe/f/Net-SNMP-v6.0.1-Switch_from_Socket6_to_Socket.patch";
-        hash = "sha256-IpVhqI+dXqzauTkLF0Doulg5U33FxHUhqFTp0jeMtMY=";
+        hash = "sha256-AlzNUkAmNSRIIZXs8v5gdp8n7fMfKyqqgM4VDpO47Bs=";
       })
-      (fetchpatch2 {
+      (fetchpatch {
         url = "https://src.fedoraproject.org/rpms/perl-Net-SNMP/raw/6e1d3e8ff2b9bd38dab48301a9d8b5d81ef3b7fe/f/Net-SNMP-v6.0.1-Simple_rewrite_to_Digest-HMAC-helpers.patch";
-        hash = "sha256-ZXo9w2YLtPmM1SJLvIiLWefw7SwrTFyTo4eX6DG1yfA=";
+        hash = "sha256-UFL1rz8HGsU1V+GypybBLvflzpAvh2DYNWjZbfjguvw=";
       })
-      (fetchpatch2 {
+      (fetchpatch {
         url = "https://src.fedoraproject.org/rpms/perl-Net-SNMP/raw/6e1d3e8ff2b9bd38dab48301a9d8b5d81ef3b7fe/f/Net-SNMP-v6.0.1-Split_usm.t_to_two_parts.patch";
-        hash = "sha256-A2gsD6DIX1aFSVLbSL/1zKSM1xiM6hWBadJJH7f5E8o=";
+        hash = "sha256-/tuPmpehUOnCsHgfSAXieQI3QZqEWr67mwohd7NVD2o=";
       })
-      (fetchpatch2 {
+      (fetchpatch {
         url = "https://src.fedoraproject.org/rpms/perl-Net-SNMP/raw/6e1d3e8ff2b9bd38dab48301a9d8b5d81ef3b7fe/f/Net-SNMP-v6.0.1-Add_tests_for_another_usm_scenarios.patch";
-        hash = "sha256-U7nNuL35l/zdSzx1jgjp1PmLQn3xzzDw9DGnyeydi2E=";
+        hash = "sha256-HDRRJTZD+u/ZHgTIx1fVr4U/0DVH92ELfOMAgY++RQE=";
       })
-      (fetchpatch2 {
+      (fetchpatch {
         url = "https://src.fedoraproject.org/rpms/perl-Net-SNMP/raw/6e1d3e8ff2b9bd38dab48301a9d8b5d81ef3b7fe/f/Net-SNMP-v6.0.1-Rewrite_from_Digest-SHA1-to-Digest-SHA.patch";
-        hash = "sha256-dznhj1Fcy0iBBl92p825InjkNZixR2MURVQ/b9bVjtc=";
+        hash = "sha256-jFz5eehV8MHFdd3Wq5S9wWCDhUr5qk4wAJ1mDRJffzw=";
       })
       ../development/perl-modules/net-snmp-add-sha-algorithms.patch
     ];

stigtsp · 2024-10-26T08:51:47Z

@ofborg build perlPackages.NetSNMP

stigtsp

Looks good to me

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 349861

`x86_64-linux`

✅ 11 packages built:

fusionInventory
munin
nagiosPlugins.check_nwc_health
nagiosPlugins.check_ups_health
ocsinventory-agent
ocsinventory-agent.devdoc
perl538Packages.NetSNMP
perl538Packages.NetSNMP.devdoc
perl540Packages.NetSNMP
perl540Packages.NetSNMP.devdoc
smokeping

nix-owners bot requested review from marcusramberg, stigtsp and zakame October 19, 2024 20:39

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 19, 2024

jwillikers force-pushed the NetSNMP-more-algos branch 2 times, most recently from 1d015f9 to fbcd0a2 Compare October 21, 2024 14:49

jwillikers changed the title ~~perlPackages.NetSNMP: add patch to support SHA-256 and SHA-512 authentication~~ perlPackages.NetSNMP: add patch to support modern SHA algorithms for authentication Oct 21, 2024

jwillikers force-pushed the NetSNMP-more-algos branch from fbcd0a2 to 7c55b6c Compare October 21, 2024 15:24

jwillikers force-pushed the NetSNMP-more-algos branch from 7c55b6c to 885c135 Compare October 23, 2024 16:36

stigtsp reviewed Oct 23, 2024

View reviewed changes

stigtsp requested changes Oct 23, 2024

View reviewed changes

jwillikers force-pushed the NetSNMP-more-algos branch 2 times, most recently from 00ef02a to a63d554 Compare October 23, 2024 19:17

jwillikers requested a review from stigtsp October 23, 2024 21:49

perlPackages.NetSNMP: fix tests

0cd2be5

jwillikers force-pushed the NetSNMP-more-algos branch from a63d554 to 2074b1f Compare October 24, 2024 15:18

jwillikers force-pushed the NetSNMP-more-algos branch from 2074b1f to cf0498e Compare October 24, 2024 16:07

stigtsp reviewed Oct 25, 2024

View reviewed changes

jwillikers added 2 commits October 25, 2024 08:27

perlPackages.NetSNMP: apply Fedora patches

9bf3f22

jwillikers force-pushed the NetSNMP-more-algos branch from cf0498e to b44ec15 Compare October 25, 2024 13:27

zakame approved these changes Oct 25, 2024

View reviewed changes

wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 26, 2024

stigtsp approved these changes Oct 27, 2024

View reviewed changes

stigtsp merged commit 0c98c85 into NixOS:master Oct 27, 2024
28 of 29 checks passed

jwillikers deleted the NetSNMP-more-algos branch October 27, 2024 13:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perlPackages.NetSNMP: add patch to support modern SHA algorithms for authentication #349861

perlPackages.NetSNMP: add patch to support modern SHA algorithms for authentication #349861

jwillikers commented Oct 19, 2024 •

edited

Loading

zakame commented Oct 20, 2024

zakame commented Oct 20, 2024

jwillikers commented Oct 20, 2024 •

edited

Loading

stigtsp commented Oct 21, 2024

jwillikers commented Oct 21, 2024

jwillikers commented Oct 21, 2024

stigtsp commented Oct 21, 2024

jwillikers commented Oct 21, 2024

jwillikers commented Oct 23, 2024

stigtsp Oct 23, 2024

jwillikers Oct 23, 2024

jwillikers Oct 23, 2024

stigtsp Oct 23, 2024

jwillikers Oct 23, 2024

stigtsp left a comment

stigtsp left a comment

jwillikers commented Oct 23, 2024

jwillikers commented Oct 23, 2024

stigtsp commented Oct 24, 2024

stigtsp commented Oct 24, 2024

jwillikers commented Oct 24, 2024 •

edited

Loading

jwillikers commented Oct 24, 2024 •

edited

Loading

stigtsp Oct 25, 2024

jwillikers Oct 25, 2024

stigtsp commented Oct 25, 2024

zakame commented Oct 25, 2024

zakame left a comment

stigtsp commented Oct 26, 2024 •

edited

Loading

stigtsp commented Oct 26, 2024

stigtsp left a comment

	url = "https://raw.githubusercontent.com/openbsd/ports/refs/heads/master/net/p5-Net-SNMP/patches/patch-lib_Net_SNMP_Security_USM_pm";
	url = "https://raw.githubusercontent.com/openbsd/ports/ab6365da3ac861e1c56520acdf388d421b357c17/net/p5-Net-SNMP/patches/patch-lib_Net_SNMP_Security_USM_pm";

		--replace "--- lib/Net/SNMP/Security/USM.pm.orig" "--- a/lib/Net/SNMP/Security/USM.pm" \
		--replace "+++ lib/Net/SNMP/Security/USM.pm" "+++ b/lib/Net/SNMP/Security/USM.pm"

perlPackages.NetSNMP: add patch to support modern SHA algorithms for authentication #349861

perlPackages.NetSNMP: add patch to support modern SHA algorithms for authentication #349861

Conversation

jwillikers commented Oct 19, 2024 • edited Loading

Things done

zakame commented Oct 20, 2024

zakame commented Oct 20, 2024

jwillikers commented Oct 20, 2024 • edited Loading

stigtsp commented Oct 21, 2024

jwillikers commented Oct 21, 2024

jwillikers commented Oct 21, 2024

stigtsp commented Oct 21, 2024

jwillikers commented Oct 21, 2024

jwillikers commented Oct 23, 2024

stigtsp Oct 23, 2024

Choose a reason for hiding this comment

jwillikers Oct 23, 2024

Choose a reason for hiding this comment

jwillikers Oct 23, 2024

Choose a reason for hiding this comment

stigtsp Oct 23, 2024

Choose a reason for hiding this comment

jwillikers Oct 23, 2024

Choose a reason for hiding this comment

stigtsp left a comment

Choose a reason for hiding this comment

stigtsp left a comment

Choose a reason for hiding this comment

jwillikers commented Oct 23, 2024

jwillikers commented Oct 23, 2024

stigtsp commented Oct 24, 2024

stigtsp commented Oct 24, 2024

jwillikers commented Oct 24, 2024 • edited Loading

jwillikers commented Oct 24, 2024 • edited Loading

stigtsp Oct 25, 2024

Choose a reason for hiding this comment

jwillikers Oct 25, 2024

Choose a reason for hiding this comment

stigtsp commented Oct 25, 2024

zakame commented Oct 25, 2024

nixpkgs-review result

x86_64-linux

zakame left a comment

Choose a reason for hiding this comment

stigtsp commented Oct 26, 2024 • edited Loading

stigtsp commented Oct 26, 2024

stigtsp left a comment

Choose a reason for hiding this comment

nixpkgs-review result

x86_64-linux

jwillikers commented Oct 19, 2024 •

edited

Loading

jwillikers commented Oct 20, 2024 •

edited

Loading

jwillikers commented Oct 24, 2024 •

edited

Loading

jwillikers commented Oct 24, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

stigtsp commented Oct 26, 2024 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`