Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

softether: 4.38 -> 4.41 #343981

Merged
merged 1 commit into from
Oct 27, 2024
Merged

softether: 4.38 -> 4.41 #343981

merged 1 commit into from
Oct 27, 2024

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 23, 2024 •
edited by RossComputerGuy
Loading

Description of changes

Update softether package to latest stable release.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from rick68 September 23, 2024 16:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 23, 2024
@6543 6543 marked this pull request as ready for review September 25, 2024 15:26
@RossComputerGuy RossComputerGuy changed the title Softether 4.41 softether: 4.38 -> 4.41 Oct 25, 2024
@RossComputerGuy RossComputerGuy self-assigned this Oct 25, 2024
@RossComputerGuy
Copy link
Member

Will take a look at this soon.

GaetanLepage
GaetanLepage requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also get rid of the with lib; in the meta attr please ?

@6543 6543 requested a review from GaetanLepage October 25, 2024 19:51
@GaetanLepage
Copy link
Contributor

Could you also get rid of the with lib; in the meta attr please ?

I think you forgot this.
Also, in src, use rev = "refs/tags/${version}"; to prevent branch/tag mismatch.

@RossComputerGuy
Copy link
Member

Also should get rid of rec and use finalAttrs.

@6543 6543 force-pushed the softether-4.41 branch 2 times, most recently from 45e7cb2 to 60c69ae Compare October 26, 2024 08:50
@6543
Copy link
Member Author

6543 commented Oct 26, 2024 •
edited
Loading

I think you forgot this.

yes sorry fixed that

GaetanLepage
GaetanLepage approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@6543
Copy link
Member Author

6543 commented Oct 26, 2024

Could you also get rid of the with lib; in the meta attr please ?

well now the build fails ... I can use the full path for e.g. maintainers ...

@GaetanLepage
Copy link
Contributor

It looks like there is an issue with your change though.
They are reported to not be parseable.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 343981

x86_64-linux

✅ 1 package built:
  • softether

aarch64-linux

x86_64-darwin

aarch64-darwin

GaetanLepage
GaetanLepage approved these changes Oct 26, 2024
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end.
I will let @RossComputerGuy have a final look and merge if everything is fine.

RossComputerGuy
RossComputerGuy approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@RossComputerGuy RossComputerGuy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image0

@RossComputerGuy RossComputerGuy merged commit b212abd into NixOS:master Oct 27, 2024
10 of 11 checks passed
@6543 6543 deleted the softether-4.41 branch October 27, 2024 16:59
@6543
Copy link
Member Author

6543 commented Oct 27, 2024

☝️ ✔️ that gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossComputerGuy RossComputerGuy RossComputerGuy approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@rick68 rick68 Awaiting requested review from rick68

Assignees

@RossComputerGuy RossComputerGuy

Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@6543 @RossComputerGuy @GaetanLepage