Skip to content

Commit

Permalink
workflows/eval: fail hard without target run
Browse files Browse the repository at this point in the history
Without a target run, we won't get any rebuild labels, rebuild counts or
maintainer pings. This might have been correct before #373935, but by
now we run eval on all commits on the target branch, so we should treat
it as a failure if we can't find the run.

(cherry picked from commit 86a38d4)
  • Loading branch information
wolfgangwalther authored and github-actions[bot] committed Feb 4, 2025
1 parent e5c4b48 commit 0efb3c5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/eval.yml
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ jobs:
--jq '.workflow_runs | sort_by(.run_started_at) | .[-1]') \
|| [[ -z "$run" ]]; then
echo "Could not find an eval.yml workflow run for $BASE_SHA, cannot make comparison"
exit 0
exit 1
fi
echo "Comparing against $(jq .html_url <<< "$run")"
runId=$(jq .id <<< "$run")
Expand All @@ -189,7 +189,7 @@ jobs:
if [[ "$conclusion" != "success" ]]; then
echo "Workflow was not successful (conclusion: $conclusion), cannot make comparison"
exit 0
exit 1
fi
echo "targetRunId=$runId" >> "$GITHUB_OUTPUT"
Expand Down

0 comments on commit 0efb3c5

Please sign in to comment.