Add assigner executable #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akokoshn
force-pushed
the
add_assigner
branch
7 times, most recently
from
94df9cf to
2ef70bd
Compare
makxenov
reviewed
Apr 1, 2024
akokoshn
force-pushed
the
add_assigner
branch
2 times, most recently
from
8ddd03d to
f698a5d
Compare
makxenov
reviewed
Apr 3, 2024
aleasims
suggested changes
Apr 3, 2024
|
As far as I see, build of assigner is not done at CI. We should add a step for that. |
akokoshn
force-pushed
the
add_assigner
branch
6 times, most recently
from
573b5c4 to
3345f32
Compare
aleasims
suggested changes
Apr 4, 2024
aleasims
suggested changes
Apr 4, 2024
akokoshn
force-pushed
the
add_assigner
branch
3 times, most recently
from
be9fdeb to
b24b9c5
Compare
aleasims
reviewed
Apr 4, 2024
akokoshn
force-pushed
the
add_assigner
branch
5 times, most recently
from
f31604d to
d36d500
Compare
akokoshn
force-pushed
the
add_assigner
branch
2 times, most recently
from
85e350a to
2b3c27c
Compare
aleasims
suggested changes
Apr 17, 2024
There was a problem hiding this comment.
Also we can add apps to outputs of flake.nix here to define assigner as Nix app. This will allow to build and run assigner like this:
nix run .#assigner
Apps definition in flake.nix outputs looks something like this:
packages = ...
checks = ...
apps = forAllSystems ({ pkgs }: {
assigner = {
type = "app";
program = "${self.packages.${pkgs.system}.default}/bin/assigner";
};
});
bin/assigner/CMakeLists.txt
Outdated
|
|
||
| add_executable(${TARGET_NAME} ${SOURCES}) | ||
|
|
||
| target_compile_options(${TARGET_NAME} PRIVATE -std=c++23) |
There was a problem hiding this comment.
I think there is a special property defining C++ standard (CXX_STANDARD or CMAKE_CXX_STANDARD)
Also, do we really use such new standard?
There was a problem hiding this comment.
we need it for intx from evm-assigner
aleasims
suggested changes
Apr 17, 2024
aleasims
reviewed
Apr 18, 2024
added 2 commits
April 18, 2024 18:09
akokoshn
force-pushed
the
add_assigner
branch
2 times, most recently
from
7213cef to
d3b40d5
Compare
aleasims
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.