[loadgen] main-keys-path parameter removed #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Un1oR
force-pushed
the
feature/do-not-use-main-keys-path-for-loadgen
branch
from
9c6f952 to
aefe95e
Compare
olegrok
approved these changes
Mar 4, 2025
Un1oR
force-pushed
the
feature/do-not-use-main-keys-path-for-loadgen
branch
from
aefe95e to
b80cd15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cliservice.NewServiceaccepts the private key of the smart account, with which the corresponding smart account management commands will work. We don't useMainSmartAccountfor anything in the load generator, so we don't need credentials from it. Instead, we useFaucet, which does not require authentication.At the same time, the presence of the flag introduces an inconvenience for local debugging. Since
MainPrivateKeyis now only saved to the filesystem when usingnil gen-configs, we can't just do anil runand then direct the load generator to that instance, we have nowhere to get theMainPrivateKeyfile. I think this adds an inconvenience that is not necessary at all in this case. Let our tools require as much bodywork as possible for a minimally working setup.N.B. Also need to roll back the corresponding PR in
infra