Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI with build and linting #80

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Add CI with build and linting #80

merged 10 commits into from
Oct 23, 2024

Conversation

kisialiou
Copy link
Contributor

  • Added simple CI with Clippy.
  • Made minor changes to address points underlined by clippy.

@kisialiou kisialiou linked an issue Oct 18, 2024 that may be closed by this pull request
Add CI/CD workflow #67
Closed
karim-en
karim-en reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@karim-en karim-en left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contract isn't compilable anymore, please run RUSTFLAGS='-C link-arg=-s' cargo build --target wasm32-unknown-unknown --release

@karim-en karim-en self-requested a review October 21, 2024 12:28
@kisialiou kisialiou force-pushed the testing/init_develop branch 2 times, most recently from 559fea6 to f85b526 Compare October 21, 2024 13:12
@kisialiou kisialiou changed the title Initialize testing for the project Add CI with build and linting Oct 21, 2024
@kisialiou kisialiou force-pushed the testing/init_develop branch from 8d36a10 to e1f708c Compare October 21, 2024 13:49
@kisialiou
Copy link
Contributor Author

The contract isn't compilable anymore, please run RUSTFLAGS='-C link-arg=-s' cargo build --target wasm32-unknown-unknown --release

I fixed this and added an additional job which checks that the project is built with these flags and under the target.

@olga24912 olga24912 mentioned this pull request Oct 21, 2024
Closed
karim-en
karim-en requested changes Oct 21, 2024
View reviewed changes
@kisialiou kisialiou requested a review from karim-en October 22, 2024 15:14
@kisialiou kisialiou force-pushed the testing/init_develop branch 2 times, most recently from 8455226 to 77d84f0 Compare October 23, 2024 05:09
@kisialiou kisialiou force-pushed the testing/init_develop branch from 77d84f0 to a483040 Compare October 23, 2024 07:08
@kisialiou @karim-en
Update near/omni-prover/wormhole-omni-prover-proxy/src/lib.rs
da3bc6c 
Co-authored-by: Karim <karim.alabtakh@nearone.org>
@kisialiou kisialiou requested a review from karim-en October 23, 2024 11:27
karim-en
karim-en requested changes Oct 23, 2024
View reviewed changes
karim-en
karim-en requested changes Oct 23, 2024
View reviewed changes
@karim-en karim-en merged commit b7a25b3 into develop Oct 23, 2024
3 checks passed
@karim-en karim-en mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olga24912 olga24912 olga24912 approved these changes

@karim-en karim-en karim-en approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI/CD workflow
3 participants
@kisialiou @olga24912 @karim-en