Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up CI and modernize tests #140

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Speed up CI and modernize tests #140

merged 6 commits into from
Nov 26, 2024

Conversation

r-near
Copy link
Contributor

@r-near r-near commented Nov 23, 2024 •
edited
Loading

⚡️ Make CI 3x faster (9min → 2min 30s)!

  • Switching to nextest for parallel test execution
  • Consolidating build & test jobs to reduce GitHub Actions overhead
  • Using dtolnay/rust-toolchain instead of actions-rs/toolchain
  • Setting up proper Rust caching with workspace-aware configuration
  • Enabling aggressive crate caching for both lint and build jobs
  • Splitting test build/run for better cache utilization

Also improved test maintainability by:

  • Converting test cases to use rstest for better parameterization
  • Replacing manual test tables with cleaner #[case] syntax
  • Making test failure messages more descriptive

All checks remain the same - just way faster now 🚀

@r-near r-near changed the title Improve tests Speed up CI and modernize tests Nov 23, 2024
@r-near r-near marked this pull request as ready for review November 23, 2024 22:55
@r-near r-near requested a review from karim-en November 23, 2024 22:55
@karim-en karim-en requested a review from kisialiou November 25, 2024 23:49
@karim-en
Copy link
Collaborator

@r-near Please fix the conflict

@r-near
Copy link
Contributor Author

r-near commented Nov 26, 2024

@r-near Please fix the conflict

Fixed!

@karim-en karim-en merged commit 556e25c into main Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olga24912 olga24912 olga24912 approved these changes

@karim-en karim-en karim-en approved these changes

@kisialiou kisialiou Awaiting requested review from kisialiou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-near @karim-en @olga24912