[FEA] Qualification tool triggers the AutoTuner module #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me> Fixes NVIDIA#700 This is an incremental step toward the full automation of App migration to GPU. - Add Qual arg `--auto-tuner` to toggle the AutoTuner module. Default is Off. - Add Qual arg `--worker-info` to pass the GPU worker info to the Qual's AutoTuner. - When AutoTuner is enabled, the Qual tool will launch the AutoTuner module to make some basic recommendations/comments based on the Spark/Env properties. - A new folder `rapids_4_spark_qualification_output/tuning` is created which contains a text formatted file for each app. Each file is named after the AppID. - No unit-tests is added for now because: 1- the recommendations are based on the Profiler's implementation; and the feature is disabled by default. - There will be followup to incrementally split the logic of the AutoTuner into two classes that aim to tailor the rules/policies of the recommendations to the CPU applications.
amahussein
added
feature request
parthosa
changed the title
parthosa
reviewed
Jan 24, 2024
core/src/main/scala/com/nvidia/spark/rapids/tool/tuning/TunerContext.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
nartal1
reviewed
Jan 24, 2024
core/src/main/scala/com/nvidia/spark/rapids/tool/tuning/TunerContext.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/nvidia/spark/rapids/tool/tuning/TunerContext.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
nartal1
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) a@ahussein.me
Fixes #700
This is an incremental step toward the full automation of App migration to GPU.
--auto-tunerto toggle the AutoTuner module. Default is Off.--worker-infoto pass the GPU worker info to the Qual's AutoTuner.rapids_4_spark_qualification_output/tuningis created which contains a text formatted file for each app. Each file is named after the AppID.