You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the CollectInformation.scala checks for the environment details map "Classpath Entries" to verify that RAPIDS jars are included in the classPath.
I found out that this is not always the case. For example, some GPU eventlogs do not have the RAPIDS jars as part of the "Classpath Entries". Instead:
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
FixesNVIDIA#713, FixesNVIDIA#734
This PR changes the behavior of the AutTuner to display a comment when
the file-encoding of an application is set to a value that is not "utf-8".
The changes also improves the extraction of the RAPIDS jars values.
*Changes for 713*:
- Added a new field in `ApplicationSummaryInfo` that represents the
systemProperties
- Capture SystemProperties in the App in order to be able to check the
file-encoding
- Moved map properties to `CacheableProps` so that it can be used by the
Qualification as well.
- Moved String-conversion methods from AutTuner to StringUtils
- Moved `getEventFromJsonMethod` to EventUtils object
- Added a new UnitTest for the AutoTuner
- Updated ApplicationInfoSuite unitTests
*Changes for 734*:
- Fixed the implementation of `CollectInformation.getRapidsJARInfo`
…ons (#736)
* [FEA] AutoTuner warns that non-utf8 may not support some GPU expressions
Fixes#713, Fixes#734
This PR changes the behavior of the AutTuner to display a comment when
the file-encoding of an application is set to a value that is not "utf-8".
The changes also improves the extraction of the RAPIDS jars values.
*Changes for 713*:
- Added a new field in `ApplicationSummaryInfo` that represents the
systemProperties
- Capture SystemProperties in the App in order to be able to check the
file-encoding
- Moved map properties to `CacheableProps` so that it can be used by the
Qualification as well.
- Moved String-conversion methods from AutTuner to StringUtils
- Moved `getEventFromJsonMethod` to EventUtils object
- Added a new UnitTest for the AutoTuner
- Updated ApplicationInfoSuite unitTests
*Changes for 734*:
- Fixed the implementation of `CollectInformation.getRapidsJARInfo`
---------
Signed-off-by: Ahmed Hussein (amahussein) <a@ahussein.me>
Describe the bug
Currently the
CollectInformation.scala
checks for the environment details map "Classpath Entries
" to verify that RAPIDS jars are included in the classPath.I found out that this is not always the case. For example, some GPU eventlogs do not have the RAPIDS jars as part of the "Classpath Entries". Instead:
Some other properties to hold the RAPIDS jars:
This means that profiler will pass wrong information to the AutoTuner.
The text was updated successfully, but these errors were encountered: